Bug 41882

Summary: Batch hold modification tool updates pickup locations to disallowed libraries
Product: Koha Reporter: Sara Brown <sbrown>
Component: ToolsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: andrew, emily.lamancusa
Version: 25.11   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36135    
Bug Blocks:    

Description Sara Brown 2026-02-18 16:13:31 UTC
If a library's 'Holds and bookings policies by item type' is set to only allow pickup at an item's home library, the batch hold modification tool can still be used to update a hold's pickup location to other libraries such that the hold will never trigger to fill. To replicate:

-Set ReservesControlBranch to 'item's home library'
-Set Main library's 'Holds and bookings policies by item type' so that PASS items can only be picked up at Main
-Place a hold on a bib whose only item is a PASS belonging to Main
-Use the Batch hold modification tool to identify the hold you just placed
-Update the pickup location to North. Note that the update is successful, and there's no indication that the pickup location is now a problem.
-Check in Main's PASS, and note that the hold doesn't trigger to fill

The batch update shouldn't process for holds where the change will make the hold unfillable per a library's 'Holds and bookings policies by item type'.