| Summary: | While creating EasyAnalytics empty subfields are created | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
| Component: | Cataloging | Assignee: | Janusz Kaczmarek <januszop> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Comma delimited list of Sponsors: | Ignatianum University in Cracow |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41931: While creating EasyAnalitics empty subfields are (often) created.
Bug 41931: Unit tests Bug 41931: While creating EasyAnalitics empty subfields are (often) created. Bug 41931: Unit tests |
||
|
Description
Janusz Kaczmarek
2026-02-25 14:12:26 UTC
Created attachment 193858 [details] [review] Bug 41931: While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. Test plan: ========== 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x. 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. 6. Apply the patch ; restart_all. 7. Go to biblio #3 (!), chose Edit > Link to host record > enter the barcode. 8. Examine the biblio #3: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, with no empty subfields. 9. No new warnings. Sponsored-by: Ignatianum University in Cracow Created attachment 193859 [details] [review] Bug 41931: Unit tests Created attachment 193916 [details] [review] Bug 41931: While creating EasyAnalitics empty subfields are (often) created. In C4::Biblio::PrepHostMarcField a whole set of subfields is addes to the field 773 regardless if a respective value exists or not. This often creates empty subfields and generates warnings. Test plan: ========== 1. Set EasyAnalyticalRecords to Show. 2. Go to biblio #1, copy the barcode. 3. Go to biblio #2, chose Edit > Link to host record > enter the barcode. 4. Examine the biblio #2: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, but with empty subfields $d & $x. 5. There should be warnings in plack-intranet-error.log like: [WARN] Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. 6. Apply the patch ; restart_all. 7. Go to biblio #3 (!), chose Edit > Link to host record > enter the barcode. 8. Examine the biblio #3: a) a new "virtual" item from biblio #1 is being displayed; b) a 773 field has been inserted, with no empty subfields. 9. No new warnings. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 193917 [details] [review] Bug 41931: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |