| Summary: | Patron lists tab shows blank content when no patron lists exist | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Paul Derscheid <paul.derscheid> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 42014: Show empty state message on patron lists tab
Bug 42014: (follow-up) Only show empty state when patron is not on any list Bug 42014: Show empty state message on patron lists tab Bug 42014: (follow-up) Only show empty state when patron is not on any list |
||
|
Description
Paul Derscheid
2026-03-06 15:11:40 UTC
Created attachment 194739 [details] [review] Bug 42014: Show empty state message on patron lists tab - When no patron lists exist in the system, the patron lists tab on the patron detail page renders completely blank - Other tabs follow the convention of showing a message in the empty state (e.g. "Patron has nothing on hold.") - Add an empty state message with a link to create a new patron list, matching the established pattern To test: - Go to a patron detail page and click the "Patron lists" tab - If no patron lists exist, observe the tab is blank - Apply patch - Repeat the above steps - Verify the tab now shows "Patron is not on any list." with a link to create a new patron list - Click the link and create a patron list - Return to the patron detail page and verify the "Add patron to list" dropdown now appears instead In a case where the logged in user has permission to manage lists, "Patron is not on any list" displays even if the patron is on a list. Thanks, will check. Created attachment 194771 [details] [review] Bug 42014: (follow-up) Only show empty state when patron is not on any list - The empty state message was shown when available_lists was empty but the patron was already on all existing lists - Add !in_lists guard so the message only displays when the patron is truly not on any list Created attachment 194781 [details] [review] Bug 42014: Show empty state message on patron lists tab - When no patron lists exist in the system, the patron lists tab on the patron detail page renders completely blank - Other tabs follow the convention of showing a message in the empty state (e.g. "Patron has nothing on hold.") - Add an empty state message with a link to create a new patron list, matching the established pattern To test: - Go to a patron detail page and click the "Patron lists" tab - If no patron lists exist, observe the tab is blank - Apply patch - Repeat the above steps - Verify the tab now shows "Patron is not on any list." with a link to create a new patron list - Click the link and create a patron list - Return to the patron detail page and verify the "Add patron to list" dropdown now appears instead Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 194782 [details] [review] Bug 42014: (follow-up) Only show empty state when patron is not on any list - The empty state message was shown when available_lists was empty but the patron was already on all existing lists - Add !in_lists guard so the message only displays when the patron is truly not on any list Signed-off-by: Owen Leonard <oleonard@myacpl.org> |