Summary: | Add a syspref 'OpacPublic', to hide OPAC search-bar and force authentication on all OPAC pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | camins, mtj, nengard, savitra.sirohi |
Version: | 3.4 | ||
Hardware: | PC | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Patch for enhancement
screenshot ammended patch, as requested new 'Opac'Public' patch oops, typo... corrected patch applied to master branch |
Description
Chris Cormack
2010-05-21 01:25:25 UTC
Could you please resend this patch? I am happy to sign off on it, per the new patching rules, but the patch attached to the bug does not have your commit message, so I cannot do that. Thanks. Jared Created attachment 2620 [details] [review] ammended patch, as requested ammended patch, as requested UPDATE: Paul.P suggested on the koha list that this sys-pref be changed to 'OpacPublic', to avoid a silly double-negative i've rewritten this feature based on Paul's suggestion. new patch attached Created attachment 2813 [details] [review] new 'Opac'Public' patch applied to git tag 'v3.02.00-rc' Created attachment 2814 [details] [review] oops, typo... Created attachment 2815 [details] [review] corrected patch (In reply to comment #5) > Created attachment 2814 [details] [review] > oops, typo... bah, sshfs cached my old patch - attaching corrected patch... Created attachment 2819 [details] [review] applied to master branch applied againist master, commit e54169ba0f06cd835d72936e14012933a67793e7 Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 4289: 'OpacPublic' feature error: patch failed: installer/data/mysql/updatedatabase.pl:3876 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: opac/opac-showreviews.pl:34 error: opac/opac-showreviews.pl: patch does not apply Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merged C4/Auth.pm Auto-merged installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merged koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc Auto-merged opac/opac-detail.pl Auto-merged opac/opac-search.pl Auto-merged opac/opac-showreviews.pl Auto-merged opac/opac-suggestions.pl Auto-merged opac/opac-userupdate.pl Failed to merge in the changes. Patch failed at 0001. When you have resolved this problem run "git-am -i -3 --resolved". If you would prefer to skip this patch, instead run "git-am -i -3 --skip". nengard@debian:~/kohaclone$ This bug is mentioned in: Bug 4289: 'OpacPublic' feature http://lists.koha-community.org/pipermail/koha-patches/2010-December/013190.html Bug 4289: 'OpacPublic' feature http://lists.koha-community.org/pipermail/koha-patches/2010-December/013193.html Bug 4289 Followup: Add syspref default value and in opac.pref http://lists.koha-community.org/pipermail/koha-patches/2010-December/013192.html Bug 4289 Followup: Add syspref default value and in opac.pref http://lists.koha-community.org/pipermail/koha-patches/2010-December/013195.html Bug 4289 Followup: Add syspref default value and in opac.pref http://lists.koha-community.org/pipermail/koha-patches/2010-December/013196.html Bug 4289: 'OpacPublic' feature http://lists.koha-community.org/pipermail/koha-patches/2010-December/013205.html Bug 4289: 'OpacPublic' feature http://lists.koha-community.org/pipermail/koha-patches/2010-December/013207.html Pushed, and merged to master, please test Note: Chris N ... not for 3.2.x Follow up patch pushed This bug is mentioned in: Bug 4289 Add a syspref 'OpacPublic', http://lists.koha-community.org/pipermail/koha-patches/2011-January/013629.html Bug 4289: OpacPublic prevents login into OPAC http://lists.koha-community.org/pipermail/koha-patches/2011-January/013692.html *** Bug 7564 has been marked as a duplicate of this bug. *** |