Summary: | Display 866z summary holdings public note in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Jane Wagner <jwagner> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P3 | CC: | gmcharlt, jcamins, paul.poulain |
Version: | 3.6 | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Screen shot of OPAC display
Bug 4300: Fix display of textual holdings (866) Bug 4300: Fix display of textual holdings (866) |
Description
Chris Cormack
2010-05-21 01:25:33 UTC
Only subfield 866$z is displayed, but ; is added for each 866 field. This does only work correctly, when each 866 has a public note in $z. Example: 866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing 866 $a1-86 (1941-1987) Shows up as: Holdings Note: Some issues missing; . 866 - Textual Holdings-Basic Bibliographic Unit (R) $a - Textual holdings (NR) $x - Nonpublic note (R) $z - Public note (R) Holdings note is also only shown in OPAC, not in staff. <!-- 866 holdings public note --> <xsl:if test="marc:datafield[@tag=866]"> <span class="results_summary holdings_note"><span class="label">Holdings Note: </span> <xsl:for-each select="marc:datafield[@tag=866]"> <xsl:value-of select="marc:subfield[@code='z']"/> <xsl:choose><xsl:when test="position()=last()"><xsl:text>.</xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose> </xsl:for-each> </span> </xsl:if> Also only first $z of each 866 will be displayed, but subfield is repeatable. Created attachment 7178 [details] [review] Bug 4300: Fix display of textual holdings (866) Fixed problems: - only $z, but not $a was shown - only first $z for each 866 field was shown - each 866 field produced a ; even if no $z was present After patch was applied: - OPAC displays 866 $a and $z, separating each field with ; - Staff displays 866 $a, $x and $z, separating each field with ; Example(s) for testing: 866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing 866 $a1-86 (1941-1987) 866 $a--86 (1941-1897)$xinternal note 866 $zfirst note,$zsecond note Created attachment 7193 [details] [review] Bug 4300: Fix display of textual holdings (866) Fixed problems: - only $z, but not $a was shown - only first $z for each 866 field was shown - each 866 field produced a ; even if no $z was present After patch was applied: - OPAC displays 866 $a and $z, separating each field with ; - Staff displays 866 $a, $x and $z, separating each field with ; Example(s) for testing: 866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing 866 $a1-86 (1941-1987) 866 $a--86 (1941-1897)$xinternal note 866 $zfirst note,$zsecond note Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: small patch, everything seems OK (not tested, my setup is MARC21, I trust jared signoff & katrin patch) The original patch may have been an enhancement, but the follow-up is definitely fixing a bug. Marking as such, and for inclusion in 3.6.x. |