Summary: | C4::Biblio::GetBiblio is badly coded | ||
---|---|---|---|
Product: | Koha | Reporter: | Nahuel Angelinetti <nahuel.angelinetti> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 4321: clean C4::Biblio::GetBiblio and uses
Bug 4321: clean C4::Biblio::GetBiblio and uses Bug 4321: clean C4::Biblio::GetBiblio and uses |
Description
Chris Cormack
2010-05-21 01:25:47 UTC
Original patch here: http://lists.koha-community.org/pipermail/koha-patches/2010-March/011479.html ...followed by some discussion. It appears this patch has not been approved for 3.0.x or HEAD. Created attachment 11108 [details] [review] Bug 4321: clean C4::Biblio::GetBiblio and uses Created attachment 11345 [details] [review] Bug 4321: clean C4::Biblio::GetBiblio and uses Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 11849 [details] [review] Bug 4321: clean C4::Biblio::GetBiblio and uses Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> (In reply to comment #4) > Created attachment 11849 [details] [review] > Bug 4321: clean C4::Biblio::GetBiblio and uses > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> nice patch!, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * fb741a8 Bug 4321: clean C4::Biblio::GetBiblio and uses C4/Biblio.pm C4/ILSDI/Services.pm C4/ImportBatch.pm C4/Serials.pm catalogue/imageviewer.pl catalogue/issuehistory.pl opac/opac-imageviewer.pl * C4/Biblio.pm OK * C4/ILSDI/Services.pm OK * C4/ImportBatch.pm OK * C4/Serials.pm OK * catalogue/imageviewer.pl OK * catalogue/issuehistory.pl OK * opac/opac-imageviewer.pl OK Patch pushed to master (my opinion = not needed to push this to 3.8, it's just code cleaning. we will have time to find any unspotted problem) Thanks for this code cleaning ! Released in 3.10.0 |