|
Description
Chris Cormack
2010-05-21 01:25:54 UTC
Some further thoughts on this topic.
The goal:
* Every source file is clearly labelled with the correct copyright ownership
and license information.
* "make test" or some other tool makes sure all files continue to have
copyright and license information.
* The RM will reject patches in the future unless they make the necessary
updates to each modified file.
Some thoughts:
* Getting this up to date and keeping it there is generally good, in case
there are ever copyright disputes.
* Also good for getting Koha accepted as a package in Debian.
* Chris tells me all copyright info should be possible to pull from git.
This will allow extraction of who edited. With only about 100 committers,
some manual work to determine copyright owner for each committer should
be completely feasible, even when some people (like Chris) have worked
for different companies over the years.
- write a little tool to data mine git for authors and the time spans
they have worked in
* The exact same license statement should be used everywhere. Ideally, it
would be exactly the same as in the GPL boilerplate.
* Debian ftpmaster advice on this topic:
- http://lists.debian.org/debian-devel-announce/2003/12/msg00007.html
- http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
Created attachment 3367 [details] [review] Proposed patch Please leave this bug open, and we will just keep adding patches to fix the copyright statements Created attachment 3368 [details] [review] Another patch Created attachment 4635 [details] [review] Bug 4330 : Updating copyright statements mainpage.pl git who mainpage.pl 7 tipaul 2 Chris Cormack 2 Galen Charlton 2 acli 1 Joshua Ferraro 1 hdl 1 kados 1 rangi 1 rych 1 tgarip1957 1 tonnesen Created attachment 4636 [details] [review] Bug 4330 : Updating copyright statements for about.pl Created attachment 5028 [details] [review] Signed-off patches, squashed Comment-only change, adds information without removing any. True to the best of my knowledge. Marking as Passed QA Still many files to check, but pushed the patches Created attachment 6362 [details] [review] Bug 4330: Wrong address for Free Software Foundation Created attachment 6363 [details] [review] Bug 4330: Missing License Statement Created attachment 6364 [details] [review] Signed patch: address FSF Created attachment 6365 [details] [review] Signed patch: missing license QA: Only textual changes. patch pushed, please test Push-notes: the 2nd patch was not applying on new/bug_4330 branch: Applying: Bug 4330: Missing License Statement Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/sco/sco-main.pl CONFLICT (content): Merge conflict in opac/sco/sco-main.pl Failed to merge in the changes. Patch failed at 0001 Bug 4330: Missing License Statement When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". As it's just some comment changes, i've pushed the two patches on master directly. chris_n= can be applied on 3.6, but from pick-up the patch from master Created attachment 8174 [details] [review] Moving license scripts to misc Created attachment 8175 [details] [review] Moving license scripts to misc Second try Created attachment 8176 [details] [review] Moving license scripts to misc Should install git bz probably ;) Hmmm these scripts should stay in xt/ They are tests that should be run before release, by developers, not scripts that should be run by Koha users. Created attachment 8177 [details] [review] Followup on find-license-problems.pl Adds current directory as default argument. (In reply to comment #19) > Hmmm these scripts should stay in xt/ > > They are tests that should be run before release, by developers, not scripts > that should be run by Koha users. xt is not completely clear to me? see also 7675 xt/perltidyrc ? xt/ is tests, tests for things like template validity, missing copyrights. Not unit tests, they live in t/ t/ tests functionality xt/ tests things like translatablity, missing copyrights. It should contain things meant to be run by the installer (like you selinux paths things in bug 7675) but should definitely contain scripts to check fsf addresses xt/ is designed to contain best practice release only tests, so yes things like perltidy etc should live there. Things that don't effect functionality, but test style. OK Thanks. Obsoleting two attachments.. Created attachment 9668 [details] [review] Bug 4330 : Fixing FSF address and copyright headers Created attachment 9669 [details] [review] Bug 4330 : Fixing FSF address and copyright statements Created attachment 9670 [details] [review] Bug 4330 Fixing FSF statements Created attachment 9671 [details] [review] Bug 4330 : Adding missing license statement Created attachment 9672 [details] [review] Bug 4330 : Last of the opac files with wrong FSF address Created attachment 9675 [details] [review] Bug 4330 : Fixing FSF address and copyright headers for acqui/ Created attachment 9676 [details] [review] Bug 4330 : Adding copyright headers and fixing FSF addresses Created attachment 9789 [details] [review] Bug 4330 : Fixing FSF address and copyright headers Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9790 [details] [review] Bug 4330 : Fixing FSF address and copyright statements Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9791 [details] [review] Bug 4330 Fixing FSF statements Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9792 [details] [review] Bug 4330 : Adding missing license statement Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9793 [details] [review] Bug 4330 : Last of the opac files with wrong FSF address Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9794 [details] [review] Bug 4330 : Fixing FSF address and copyright headers for acqui/ Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 9795 [details] [review] Bug 4330 : Adding copyright headers and fixing FSF addresses Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA comment: comment only changes, adding copyright and FSF address to files that lack them. passed QA, will push patches in master, mark them as obsolete and switch back to "assigned" Comment on attachment 9789 [details] [review] Bug 4330 : Fixing FSF address and copyright headers this patch has been pushed for 3.10 Comment on attachment 9790 [details] [review] Bug 4330 : Fixing FSF address and copyright statements this patch has been pushed for 3.10 Comment on attachment 9791 [details] [review] Bug 4330 Fixing FSF statements this patch has been pushed for 3.10 Comment on attachment 9792 [details] [review] Bug 4330 : Adding missing license statement this patch has been pushed for 3.10 Comment on attachment 9793 [details] [review] Bug 4330 : Last of the opac files with wrong FSF address this patch has been pushed for 3.10 Comment on attachment 9794 [details] [review] Bug 4330 : Fixing FSF address and copyright headers for acqui/ this patch has been pushed for 3.10 Comment on attachment 9795 [details] [review] Bug 4330 : Adding copyright headers and fixing FSF addresses this patch has been pushed for 3.10 Should this bug remain open and assigned? (In reply to Owen Leonard from comment #47) > Should this bug remain open and assigned? I notice we still have a copyright line in https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence but I don't think that we're actually adding it anymore... Is this still something we shoudl/could fix? (In reply to Katrin Fischer from comment #49) > Is this still something we shoudl/could fix? I wonder this as well. I wonder if Catalyst's lawyers could advise on this one. Copyright statements in source code seems like an unclear area even these days... |