Summary: | noItemTypeImages not active in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Jane Wagner <jwagner> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, cnighswonger |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5704 | ||
Attachments: |
Proposed fix
ugly detail display |
Description
Chris Cormack
2010-05-21 01:26:15 UTC
Created attachment 2312 [details] [review] Proposed fix - Auth.pm put the noItemTypeImages preference under "intranet only." Moved it to "OPAC or intranet." - Added check for the preference on the OPAC advanced search page. - Improved logic for displaying images on the reading history page. There is now Bug 4944 for the creation of separate OPAC and staff client preferences. Patch pushed This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. Seems to be fixed in current head. Thanks. A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1. Created attachment 3080 [details]
ugly detail display
On the detail page this patch screws with the layout
Additional patches were pushed for this: http://lists.koha-community.org/pipermail/koha-patches/2010-November/012954.html http://lists.koha-community.org/pipermail/koha-patches/2010-November/012957.html The latter creates a problem, I believe, in that it causes item type images to display on the search results page even if item-level itemtypes are turned on. If item-level itemtypes are turned on a catalog might have: 1. Biblios with no biblio-level item type. 2. Biblios with multiple item-level item types. In both cases there isn't a way for Koha do properly display a single item type icon. For this reason I think display of item type icons on the search results page should be contingent on item-level_itypes being OFF. > The latter creates a problem, I believe, in that it causes item type images to > display on the search results page even if item-level itemtypes are turned on. Correction: It's not this commit that caused this item type image display problem, it was this one, for Bug 5462: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=c02e4d02d5c4ebcb01d60c4515cde3b13765fb07 Retested in current master. With 'NoItemTypeImages' set to 'Don't show': - images not shown on advanced search - images not shown in detail pages With 'NoItemTypeImages' set to 'Show' - images show on advanced search - images show on detail pages There is still only one pref for staff and OPAC. I think this should go on a separate enh bug, if we want to do this. I detected no layout problems. Closing bug, please reopen if I missed something. |