Summary: | systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Cataloging | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | P3 | CC: | fridolin.somers, kyle |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7455 | ||
Bug Blocks: | |||
Attachments: | Proposed patch |
Description
Chris Cormack
2010-05-21 01:26:29 UTC
Created attachment 12545 [details] [review] Proposed patch Simple patch. Even with hide_marc, inficators are input in biblio and authorities cataloguing. They are just hidden type. So cloning javascript method must always take care of indicators. Test plan : ----------- Set hide_marc syspref to 'don't display'. Edit a bibio/authority record with a repeatable field. For example : 606 a APPLE 606 a BANANA Save the record. In MARC you get : 606 a APPLE a BANANA With patch, record is well saved. I cannot duplicate this issue. Can you confirm that you are still seeing it in master? (In reply to comment #3) > I cannot duplicate this issue. Can you confirm that you are still seeing it > in master? Yes, it still exists on master. The cause is that whith 'hide_marc', when cloning a field, the indicator inputs are cloned without any change. So the MARC editor thinks all subfields are in the same field. I'm a bit confused. If 606 a APPLE 606 a BANANA is what I'm supposed to get, this appears to be working in master. Also, the patch no longer applies. I reproduce the bug on actual master. I rewrite test plan : - Set hide_marc syspref to "don't display" => in MARC editor, field and subfield codes are not displayed. - Create a new bibio/authority record. - On a repeatable field, write a data : 606 a APPLE - Clone this field : 606 a APPLE 606 a APPLE - Change the second field content : 606 a APPLE 606 a BANANA - Save the record. - In MARC you get the two datas in one field : 606 a APPLE a BANANA |