| Summary: | $a displayed in front of topical subjects in authority search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | MARC Authority data support | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gcollum, jwagner, m.de.rooy, nengard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
screenshot of authority search results in opac
screenshot Bug 4433: Small display problem for topical subjects Signed patch Signed patch Signed patch |
||
|
Description
Chris Cormack
2010-05-21 01:27:07 UTC
It looks like the code to remove the subfield tags was purposely commented out and replaced with an as_formatted() function in AuthoritiesMarc.pm. The code assigns value to the 'summary' variable.
Currently lines 1059 and 1060 in AuthoritiesMarc.pm.
# $heading .= $field->as_string('abvxyz68');
$heading .= $field->as_formatted();
I'm not sure for what purpose. Only the 150 field has been changed. as_formatted creates 'pretty' marc for printout purposes.
If you remove the comment from the as_string line and comment out the as_formatted line the authorities display correctly, but I'm not sure if it breaks something else.
Created attachment 4647 [details] [review] Bug 4433: Small display problem for topical subjects This removes the subfield codes shown for topical subject authorities only. To test: - Add different authority records and at least one for a topical subject. - Use search in intranet and opac (turn on opacauthorities) to serch for your subjects. - All headings will show without the subfield codes (at least $a in front), except the topical subject. This patch removes the subfield codes for the topical headings. Created attachment 4652 [details] [review] Signed patch Created attachment 4653 [details] [review] Signed patch Second try ;) Created attachment 4654 [details] [review] Signed patch Driemaal is scheepsrecht Dutch for third time lucky.. Simple change, does what it says it does. Pushed, please test |