Summary: | Adding feature to print fines/fees receipts | ||
---|---|---|---|
Product: | Koha | Reporter: | Koustubha Kale <kmkale> |
Component: | Circulation | Assignee: | Koustubha Kale <kmkale> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | amalalib09, chris, f.demians, jwagner, kmkale, oleonard |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch for adding feature to print fines/fees receipts
Revised patch. Earlier patch was failing.. Combined patch to print fee receipts and invoices Revised combined patch to print fee receipts and invoices Screenshot of print invoice screen. Screen shot of tweaked Invoice print Revised combined patch to print fee receipts and invoices Patch 2/2 Layout tweaking follow-up patch |
Description
Chris Cormack
2010-05-21 01:27:12 UTC
The latest patch still applies but introduces invalid markup in the templates. I'd also like to see the template and script names match, as is the Koha convention. (In reply to comment #1) > The latest patch still applies but introduces invalid markup in the templates. > I'd also like to see the template and script names match, as is the Koha > convention. I will change the template / scrip names to match. Could you please help me by pointing out the invalid markup? I use a Firefox add-on called "Web Developer Toolbar" which offers a tool called "Validate Local HTML." It automatically submits the source of your page to the W3C validtor (required for staff pages since the validator can't access pages which require a login). The validator points out errors like: - unquoted attributes: colspan=3 should be colspan="3" - unescaped & symbols. & should be & - <tfood> must be positioned right after <thead> in table markup - <script> tags should say <script type="javascript"> (the language attribute is not used) Created attachment 2691 [details] [review] Revised combined patch to print fee receipts and invoices 18-Oct-2010 Changed template and script names to match. Corrected invalid markup in the templates. Pushed to new/enh/bug_4440 Please test and let me know if it performs as it should, then I will merge to master > Please test and let me know if it performs as it should, then I will merge to > master My comment here: http://lists.koha-community.org/pipermail/koha-patches/2010-November/012853.html Created attachment 2745 [details]
Screenshot of print invoice screen.
Screenshot of print invoice screen.
Cant see any border outside the amounts table as commented by Frédéric Demians
(In reply to comment #6) > My comment here: > > http://lists.koha-community.org/pipermail/koha-patches/2010-November/012853.html 1) In India its customary to list party name on the next line after To, 2) In the Invoice / Free receipt print page I cant find any double border / border outside amounts table as mentioned by Frédéric Demians. Please see a screen shot attached from my system. Please guide on what needs to be done about this. (In reply to comment #8) > 2) In the Invoice / Free receipt s/Free/Fee For me, the borders should surround only the Date / Description of charge / Amount table, and not extend to the above section Library name, INVOICE label and recipient. INVOICE should be bigger and library name smaller. But I understant that it depends of regional taste... I just have reservations about the layout not about the functionality which is great and effective. I will propose a layout tweaking patch. Thanks Koustubha. (In reply to comment #11) > http://lists.koha-community.org/pipermail/koha-patches/2010-November/012967.html Thanks Frédéric. New to this so what happens now? This bug is mentioned in: Bug 4440: Revised combined patch to print fee receipts and invoices http://lists.koha-community.org/pipermail/koha-patches/2010-October/012695.html Created attachment 2753 [details]
Screen shot of tweaked Invoice print
I really like the centered INVOICE and Branch name.
So what do you think of the attached screen shot which encloses the whole thing with a border top and makes Bill To: Name on a single line?
> I really like the centered INVOICE and Branch name.
> So what do you think of the attached screen shot which encloses the whole thing
> with a border top and makes Bill To: Name on a single line?
I understand. It's perfect for me. Thanks.
Created attachment 2758 [details] [review] Revised combined patch to print fee receipts and invoices Patch 1 of 2 Second patch contains the tweaks as discussed with Frederic. Created attachment 2759 [details] [review] Patch 2/2 Layout tweaking follow-up patch Patch 2 of 2 This patch contains the layout tweaks as discussed with Frederic. Pushed and merged, please test and close |