Bug 4488

Summary: OPAC reports incorrect hold limit in warning
Product: Koha Reporter: Owen Leonard <oleonard>
Component: Hold requestsAssignee: Kyle M Hall <kyle.m.hall>
Status: NEW --- QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: gmcharlt, katrin.fischer
Version: master   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8238
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12200
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Chris Cormack 2010-05-21 01:27:46 UTC


---- Reported by oleonard@myacpl.org 2010-05-12 12:47:07 ----

The warning which appears in the OPAC when a patron has reached their holds limit reads "Sorry, you cannot place more than X holds." X should be the actual holds limit, but what appears is the actual count of holds the patron has. If the patron has *exceeded* the number of allowed holds (as is currently possible when placing multiple holds), the actual count will not match the limit.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4488 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4488

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2010-10-12 15:02:46 UTC
If C4::Reserves::CanBookBeReserved is already doing the queries to check whether something can be placed on hold, can we get it to return the maximum and current holds numbers at the same time?
Comment 2 Katrin Fischer 2019-05-04 13:20:50 UTC
I wonder how to make this easy to understand for users. We now have several limits that could trigger:

- system preference maxreserves for a global limit
- limits on number of holds per record in circ rules
- limits on number of holds per itemtype in circ rules

Especially for the settings in circ rules giving a good feedback to the user might be really difficult as library and itemtypes (might be different on the same record) can also play a role.