Bug 4498

Summary:	Acq always shows '1 suggestions waiting'
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Acquisitions	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	normal
Priority:	PATCH-Sent (DO NOT USE)	CC:	dev_patches, gcollum, nengard, robin
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	screenshot Proposed fix

Description Chris Cormack 2010-05-21 01:27:53 UTC



---- Reported by katrin.fischer@bsz-bw.de 2010-05-12 22:26:12 ----

Created an attachment
screenshot

In navigation of acquisitions there is always a link with '1 suggestions waiting' even when table suggestions is empty.

Both '1 suggestions waiting' and 'Manage suggestions' link to suggestions.pl.



---- Additional Comments From gcollum@gmail.com 2010-05-18 21:18:33 ----

It looks like <!-- TMPL_IF name="suggestion" --> in acquisitions-menu.inc is pulling its value from a global variable defined in Auth.pm - suggestion => C4::Context->preference("suggestion").  If patron suggestions are turned on you get a message indicating that there is one suggestion pending, if not you get a message that indicates that there are no messages.

This could easily be fixed by changing the variable name to something like 'pendingsuggestions' and using the CountSuggestion function in Suggestions.pm to acquire a value, but does this code need to be in every .pl file whose template will include acquisitions-menu.inc, or can it be defined as a global module variable in either Suggestions.pm, or Acquisitions.pm?



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4498 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4498
Imported an attachment (id=2131)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2131 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2010-05-31 10:32:49 UTC

*** Bug 4825 has been marked as a duplicate of this bug. ***

Comment 2 Owen Leonard 2010-08-25 19:33:39 UTC

Created attachment 2573 [details] [review]
Proposed fix

- Removing 'suggestions waiting' link from left-hand menu. A plain 'suggestions' 
  link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
  on the Acquisitions home page. This will show, with a count of pending 
  suggestions, only if suggestions are turned on and there are pending 
  suggestions.

Comment 3 Katrin Fischer 2010-09-07 14:32:36 UTC

Tested successfully with current 3.01.00.145, signed off and resend to list.

Sys pref suggestion ON/OFF
Added new suggestion, recected and accepted suggestions

Comment 4 Katrin Fischer 2010-11-12 07:18:03 UTC

Patch still applies to HEAD.

Comment 5 Katrin Fischer 2010-11-14 12:02:09 UTC

Successfully tested on current master.

Comment 6 Chris Nighswonger 2010-11-18 03:15:16 UTC

This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.

Comment 7 Katrin Fischer 2010-11-23 11:17:19 UTC

Tested ok in 3.2.1