Summary: | Confirmation messages in opac account not translated | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Proposed fix |
Description
Chris Cormack
2010-05-21 01:27:57 UTC
Created attachment 2199 [details] [review] Proposed fix Strings within JavaScript onclick attributes are not getting picked up by the translator: onclick="return confirmDelete(_('Are you sure you want to cancel this hold?'));" This patch converts those to use variables defined in the main script block: onclick="return confirmDelete(MSG_CONFIRM_DELETE_HOLD);" Patch pushed. Please test and close. Owen's patch solved the translation problem. Thx! |