Summary: | aqbudgets.pl - possibility to show / hide the filters menu | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Acquisitions | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jcamins, oleonard |
Version: | 3.4 | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
possibility to show / hide the filters menu
[replace previous] bug 4523 possibility to show hide the filters menu |
Description
Chris Cormack
2010-05-21 01:28:10 UTC
Marking as enhancement. This patch needs review; while it works well enough, the notion of adding a show/hide filter link that has no equivalent in any other staff interface page seems to me to make the UI unnecessarily inconsistent. I agree with Galen. This looks like a useful feature, but I think it would be a good idea for us to spend some time thinking about a global method and style for this kind of interaction. We've already established a pattern for sidebar filters, we should to the same for this kind of interaction as well. Pushed patch to new/bug4523 topic branch for consideration in 3.4; as previous comments imply, however, if this is to be done, it ought to be done consistent, not just for a single page. The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks Needs a new patch, written for template toolkit Not sure why this isn't marked as having been pushed to master. It appears to have been in Koha since 2010. |