Bug 4920

Summary:	neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Product:	Koha	Reporter:	Dobrica Pavlinusic <dpavlin>
Component:	Acquisitions	Assignee:	Henri-Damien LAURENT <henridamien>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	minor
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, m.de.rooy
Version:	rel_3_2
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	remove onload

Description Dobrica Pavlinusic 2010-06-30 11:43:17 UTC

Currently, modifying existing orders will recalculate values if exchange rate has changed, which destroys previous data (our use case is just to modify Planning value fields).

Since fileds also have onChange event which also triggers caclNeworderTotal, onload event seems redundant.

Comment 1 Dobrica Pavlinusic 2010-06-30 11:57:35 UTC

Created attachment 2288 [details] [review]
remove onload

submited to koha-patches

Comment 2 Marcel de Rooy 2010-12-20 12:09:20 UTC

Tested. Signed off.

Comment 3 MJ Ray (software.coop) 2011-01-08 11:13:12 UTC

This bug is mentioned in:
Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload http://lists.koha-community.org/pipermail/koha-patches/2010-December/013431.html

Comment 4 Chris Cormack 2011-01-17 08:14:25 UTC

Pushed, please test