Bug 4946

Summary: hold warning needs rewording
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: minor    
Priority: PATCH-Sent (DO NOT USE) CC: chris
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Confirmation when item is checked out to another patron
Confirmation when item is on hold for another patron
Confirmation when item is already checked out to the patron
Confirmation when item is waiting for another patron
Confirmation when patron has too many checked out
Proposed fix

Description Nicole C. Engard 2010-07-06 20:28:04 UTC
When you try to check out an item that is on hold for someone else the wording of the message is confusing: 

  "Item is on hold for 2010-05-13 : Jordan Alford (23529000050113)"

It should instead read:

  "Item is on hold for Jordan Alford (23529000050113) since 2010-05-13"

or whatever the date is that's listed - but right now it looks like it's on hold for the date ...
Comment 1 Owen Leonard 2010-07-08 13:56:53 UTC
Created attachment 2325 [details]
Confirmation when item is checked out to another patron

Now with additional information.
Comment 2 Owen Leonard 2010-07-08 13:57:23 UTC
Created attachment 2326 [details]
Confirmation when item is on hold for another patron

Now with additional information.
Comment 3 Owen Leonard 2010-07-08 13:58:44 UTC
Created attachment 2327 [details]
Confirmation when item is already checked out to the patron

Now with additional information
Comment 4 Owen Leonard 2010-07-08 13:59:11 UTC
Created attachment 2328 [details]
Confirmation when item is waiting for another patron

Now with additional information
Comment 5 Owen Leonard 2010-07-08 14:40:33 UTC
Created attachment 2329 [details]
Confirmation when patron has too many checked out

Improved phrasing
Comment 6 Owen Leonard 2010-07-08 14:48:08 UTC
Created attachment 2330 [details] [review]
Proposed fix

This patch improves the phrasing of several messages by breaking the message variable into distinct parts for more natural-sounding warnings when:
    
    - Checking out an item on hold for another patron
    - Checking out an item which is waiting for another patron
    - Checking out an item which is checked out to another patron
    - Checking out an item which is checked out to this patron
    - Checking out to a patron who has too many checked out
    
I would appreciate special attention to my changes to the TooMany function in Circulation.pm to make sure I handled it correctly.
Comment 7 Chris Cormack 2010-12-16 20:45:45 UTC
Patch pushed, please test