| Summary: | checkbox should be removed when can't place a hold | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/opac-reserve.pl?biblionumber=804 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
can't place hold
Updated interface hides form controls for items which can't be placed on hold Updated interface hides even more controls when no items can be placed on hold Proposed fix Revised for current HEAD Proposed fix for 3.2.x |
||
Created attachment 2342 [details]
Updated interface hides form controls for items which can't be placed on hold
Created attachment 2343 [details]
Updated interface hides even more controls when no items can be placed on hold
Created attachment 2344 [details] [review] Proposed fix Fixes include: - Hiding form controls for titles which can't be placed on hold - Highlighting hold blocked message for better visibility - Showing table of blocked holds even if none can be placed on hold: hiding the table hides the messages explaining why titles can't be placed on hold - Removing an unused line from the script which was leaving errors in the error log - Consolidating error messages into one box which were displaying in two. - Correcting link to unused opac-userdetails.pl Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-4950-opac-holds-checkbox-2010-07-09 Created attachment 2947 [details] [review] Revised for current HEAD Pushed please test Created attachment 2959 [details] [review] Proposed fix for 3.2.x This bug is mentioned in: Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013520.html Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013532.html Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013513.html Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013541.html |
Created attachment 2315 [details] can't place hold When you can't place a hold in the opac, a checkbox still appears to the left of the item making it looks like you should be able to click it and making you overlook the warning saying you can't