| Summary: | process_koc.pl fails to process returns because of \r | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
I was having trouble processing koc-files with /cgi-bin/koha/offline_circ/process_koc.pl. I got this message, both for items that were on loan and items that were not on loan: "Warning: Unable to determine patron from item barcode (71556236). Cannot check in." 71556236 is a valid barcode. This hack on around line 192 of offline_circ/process_koc.pl fixes it: sub parse_command_line { my $command_line = shift; chomp($command_line); $command_line =~ s/\r//g; Comments from IRC: [20:04] pianohack: magnus: Are these windows-style \r\n lines? [20:04] magnus: pianohack: probably [20:04] pianohack: magnus: All chomp does is remove the line ending on the platform you're running on [20:04] pianohack: linux server, windows client? [20:04] magnus: yup [20:05] magnus: adding $command_line =~ s/\r//g; solves it [20:05] gmcharlt: s/\r$//g; would be slightly more precise [20:05] pianohack: magnus: You might consider just replacing chomp entirely with s/[\r\n]*$//g [20:05] pianohack: No reason to have both, I don't think