Summary: | reintegrate overdues email in overdue list | ||
---|---|---|---|
Product: | Koha | Reporter: | Nahuel Angelinetti <nahuel.angelinetti> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, josef.moravec, katrin.fischer |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Patch for HEAD proposed |
Description
Nahuel Angelinetti
2010-07-13 13:54:04 UTC
Created attachment 2434 [details] [review] Patch for HEAD proposed Comment on attachment 2434 [details] [review] Patch for HEAD proposed This patch introduces an error. The feature was pushed to 3.0.x and should be added to 3.2 too. 3.0.x: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=a8441dfabf5c2b561b6ba93c084a88072a910043 Ill rebase it on master, and push it up for people to test Cherry picked, conflict fixed and pushed to new/awaiting_qa/bug_4990 Unfortunately this cherry-pick wont work, that file diverged from master significantly in the 3.0.x. The work will need to be redone. I'm going to revert the cherry-pick and will work on the fix and push that up for qa Instead of reverting, I have pushed an attempted fix for testing. That looks a lot better, but we are not quite there yet. 1. Umlauts and diacritics are broken - encoding problem? 2. A lot of the placeholders are not parsed. I didn't manage to get the list of items into the notice. That's the template I tried: Dear <<borrowers.firstname>> <<borrowers.surname>>, <<branches.branchname>> <<branches.branchaddress1>> <<branches.branchaddress2>> <<branches.branchaddress3>> <<branches.branchphone>> <<branches.branchfax>> <<branches.branchemail>> <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>EUR</fine></item> <<items.content>> <<biblio.title>> <<biblio.author>> <<items.barcode>> Thank you, <<branches.branchname>> äöüß& ------------------------- That's the output: Dear Katrin Fischer, HFJS/Zentralarchiv <item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>EUR</fine></item> <<biblio.title>> <<biblio.author>> <<items.barcode>> Thank you, HFJS/Zentralarchiv äöüß -------------- Branchname and name of borrower seem to work. This feature is still missing in current master. Resetting assignee and setting bug to NEW. Feature didn't work since 3.0.x, so probably can be considered an enhancement by now. I tried to reintegrate mailto links in the past but ran into issues with complex text and diacritics. I believe if manually generating overdue notices is a requirement, we'd need a new approach. Closing this for now. |