|Summary:||ldap search always anonymous when using auth_by_bind|
|Product:||Koha||Reporter:||Dobrica Pavlinusic <dpavlin>|
|Component:||Authentication||Assignee:||Dobrica Pavlinusic <dpavlin>|
|Status:||CLOSED FIXED||QA Contact:||Bugs List <koha-bugs>|
|Priority:||PATCH-Sent (DO NOT USE)||CC:||chris, ohiocore|
|Change sponsored?:||---||Patch complexity:||---|
|Text to go in the release notes:||Version(s) released in:|
do bind just once
Signed off patch
Description Dobrica Pavlinusic 2010-07-13 19:07:26 UTC
When using auth_by_bind, search was always done as anonymous user. This is a problem if we want to fetch LDAP values which have ACL permissions only for users.
Comment 1 Dobrica Pavlinusic 2010-07-13 19:20:00 UTC Comment hidden (obsolete)
Created attachment 2357 [details] [review] do bind just once This change moves bind from search_method back into checkpw_ldap, making code cleaner and easier to understand
Comment 2 Chris Cormack 2011-05-09 21:59:26 UTC
Created attachment 4069 [details] [review] Signed off patch
Comment 3 Joe Atzberger 2011-06-15 23:06:36 UTC
Please do not apply both this AND the fix for 5094 without testing them together. Conflict is likely as they do not anticipate each other.
Comment 4 Dobrica Pavlinusic 2011-06-17 00:35:50 UTC
I did some testing with our setup (replicate without update) at they work fine together. We have a two more tests which use WWW::Mechanize to create user in Koha to test full-cycle between our LDAP server, ldap-rewrite and koha at: http://svn.rot13.org/index.cgi/virtual-ldap/browse/t/koha
Comment 5 Chris Cormack 2011-06-17 02:39:10 UTC
Dobrica, that is great, pushing the patch now, can you please run your tests against master.
Comment 6 Dobrica Pavlinusic 2011-07-14 15:32:59 UTC
Tested, it works fine, thanks.