Summary: | extended attributes replication from LDAP | ||
---|---|---|---|
Product: | Koha | Reporter: | Dobrica Pavlinusic <dpavlin> |
Component: | Authentication | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, dev_patches, dpavlin |
Version: | rel_3_0 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4256 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | fix mapping of extended attribute code and ldap attributes |
Description
Dobrica Pavlinusic
2010-07-13 21:39:27 UTC
Created attachment 2360 [details] [review] fix mapping of extended attribute code and ldap attributes This approach still require additional entry in koha-conf.xml mapping like this: <JMBG is="hrEduPersonUniqueNumber_JMBG"></JMBG> It's quite easy to add code to match existing types in extended attributes to ldap attribute names directly, so that it doesn't require change in koha-conf.xml, but I can see also argumentation against it along the lines of "it's really nice to have all LDAP configuration in one place in koha-conf.xml and I like ability to rename fields". Applied I can't see this patch applied in current master. It would bring current LDAP implementation into fully-functional state, and still applies cleanly to master. It is there in master already, applying the patch causes this conflict
<<<<<<< HEAD
my @attributes = grep{my $key=$_; any{$_ eq $key}@types;} keys %borrower;
my $extended_patron_attributes;
@{$extended_patron_attributes} =
map { { code => $_, value => $borrower{$_} } } @attributes;
=======
my @attributes = grep{my $key=$_; any{$_->{code} eq $key}@types;} keys %borrower;
my $extended_patron_attributes = [ map{{code=>$_,value=>$borrower{$_}}}@attributes ];
>>>>>>> Bug 4995 - extended attributes replication from LDAP
|