Summary: | add autocomplete="off" to borrowernumbers and barcode forms | ||
---|---|---|---|
Product: | Koha | Reporter: | Dobrica Pavlinusic <dpavlin> |
Component: | Browser compatibility | Assignee: | Dobrica Pavlinusic <dpavlin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, nengard, paul.poulain |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
add autocomplete=off
Bug 5009 : Turning off autocomplete Signed-off patch |
Description
Dobrica Pavlinusic
2010-07-14 19:51:13 UTC
Created attachment 2365 [details] [review] add autocomplete=off This sounds like a browser configuration issue rather than a Koha bug. It's possible to tell your browser not to save form data. I'd prefer to leave it up to the user to decide. I disagree with you owen: yes, it's a browser configuration, but it's a "all or none" configuration. User always find autocomplete usefull, and I agree it sometimes causes problem with barcode (it has already been reported by some of our customers) So I think we should force autocomplete=off for circulation. Reopening the bug, I think this patch is worth being included ! I have applied this patch fine, but can't sign off on it. When you're on any page other than the circ page and you type in the 'check out' box at the top auto complete still works. It also still works when adding a new patron. This patch doesn't modify behavior of CircAutocompl system setting. If it is used, Koha will still show autocomplete (just not browser auto-complete which looks a bit different). Does that clears up confusion? When I'm adding a new patron and I type in the barcode box it still tries to complete what I'm typing ... so that shouldn't happen based on the description. It does not try to complete when I'm When I'm on a page other than the main circ page (for example: cgi-bin/koha/reports/borrowers_out.pl) if I type in the 'check in' box it tries to auto complete that - that's not controlled in the system preference. I guess I need to know what pages this patch should stop auto complete on to test properly. Patch needs to be rewritten for Template:Toolkit. Created attachment 4582 [details] [review] Bug 5009 : Turning off autocomplete Files affected koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Created attachment 4602 [details] [review] Signed-off patch Simple html change, works as advertised, pushed please test |