Summary: | Inconsistent use of ordering price and list price in vendor form | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/supplier.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
screenshot of new vendor form
screenshot after changes proposed patch |
Created attachment 2421 [details]
screenshot after changes
Created attachment 2422 [details] [review] proposed patch Changes Ordering price to List price and makes spelling more consistent. Rebased to HEAD without any conflicts. Patch pushed test and close Tested with HEAD. This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. Successfully tested with 3.2.1 |
Created attachment 2420 [details] screenshot of new vendor form The vendor form uses the terms list price for currency and ordering price for tax information. After discussion in IRC we came to the conclusion that both terms have the same meaning. 07-26-2010 (12:16:19) chris: i think in the context of the vendor form its the same (12:16:25) chris: thats how the code uses it anyway (12:17:09) chris: it will use the currency chosen to convert the price, then if there is tax then subtract that, then remove the discount (12:18:29) chris: to end up with the estimated cost, so the currency of list price and tax of ordering price are both used for the same thing