Bug 5082

Summary: Not translatable name of default framework 'Default' in MARCdetail.tmpl
Product: Koha Reporter: Serhij Dubyk <dubyk>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, cnighswonger, dubyk, julian.maurice
Version: rel_3_0   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 766    
Attachments: Proposed fix for HEAD
Proposed fix for 3.0.x

Description Serhij Dubyk 2010-08-03 10:36:13 UTC
In MARCdetail.tmpl is present simple markup

<!--TMPL_VAR Name="framework" -->

and this value readed by MARCdetail.pl from table `biblio_framework`

but for default framework I see next code in MARCdetail.pl

my $curfwk;
push @select_fwk, "Default";
$select_fwk{"Default"} = "Default";

and this not translatable

In addbiblio.tmpl "Default" is present and translatable.
Comment 1 Owen Leonard 2010-08-03 12:45:52 UTC
Created attachment 2444 [details] [review]
Proposed fix for HEAD

This patch also fixes an unreported bug where switching from any other framework to 'Default' would bring up no MARC data.
Comment 2 Owen Leonard 2010-08-03 13:44:08 UTC
Created attachment 2445 [details] [review]
Proposed fix for 3.0.x
Comment 3 Chris Cormack 2010-11-04 08:02:15 UTC
Patch pushed to head, please test and close
Comment 4 MJ Ray (software.coop) 2010-11-10 08:49:25 UTC
This bug is mentioned in:
Fix for Bug 5082 - Not	translatable name of default framework 'Default' in MARCdetail.tmpl http://lists.koha-community.org/pipermail/koha-patches/2010-October/012793.html
Comment 5 Chris Nighswonger 2010-11-18 03:15:28 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 6 Chris Nighswonger 2010-11-30 13:49:35 UTC
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1.

Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.