Summary: | auth_by_bind authentication can fail even if given a correct password and userid | ||
---|---|---|---|
Product: | Koha | Reporter: | Jeremy Crabtree <JeremyC> |
Component: | Authentication | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, dpavlin, JeremyC, melia, ohiocore, wallen_tan |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Proposed fix for this bug |
Description
Jeremy Crabtree
2010-08-05 14:22:14 UTC
Created attachment 2474 [details] [review] Proposed fix for this bug This is a proposed fix for this bug. It skips the creation of $userldapentry if neither updating nor replicating are enabled. Confirm bug from d114ebe80adc7b2c34d08d94c17d302b3ddda4be. search_method must NOT be called if bind has already occurred, because it will bind again and with different credentials depending on config (likely anonymously). This is important for auth_by_bind for obvious reasons, mainly that Active Directory doesn't allow you to view the same record anonymously that you would get when bound as the user. Even if it were successful (which it isn't), binding twice is logically incorrect and bad for performance. The amount of complexity in the LDAP code is seriously regrettable. Tested OK with auth_by_bind, no replicate, no update, no static bind user/pass. Patch sent to the list. Adding patch status. Increasing importance. This is actually a blocker for LDAP to Active Directory w/ a given config. Pushed to master, welcome to the Koha committer family Jeremy Dobrica, can you please run your tests against master. Testeda against current master, it works fine, thanks. I would remove comment line with FIXME dpavlin from it, since it is unneeded left-over :-) Reopening in hopes that we can get update/replicate to work. Proposing Bug 7099 with a fix It deals with the Update/Replicate problem in ActiveDirectory (made a separate bug since its not related to the title) *** Bug 7099 has been marked as a duplicate of this bug. *** (In reply to comment #7) > Reopening in hopes that we can get update/replicate to work. Current master at http://git.koha-community.org includes this fix. |