|
Description
Robin Sheat
2010-08-30 04:06:22 UTC
Created attachment 2584 [details] [review] Makes the packages use the bundled version of jquery This forces the packages to use the version of jquery that comes with koha, rather than the system version. It's a stopgap until real changes allow us to track the newer versions. I found another error that occurs with the newer jQuery: the opac patron's details page selects the 'Fines & Charges' tab by default, but appears as though it's selected the 'Checkouts' list. > I found another error that occurs with the newer jQuery: the opac patron's > details page selects the 'Fines & Charges' tab by default I'm hoping that we can coordinate the jQuery upgrade with the addition of jQueryUI and at least partial implementation of the YUI replacement. I've made a lot of progress towards that, including a reimplementation of tabs. My work can be found in a branch called "ip-bug-5481-jquery-ui-2010-12-09" at http://gitorious.org/koha-dev/koha-dev it's not only the opac, it's also in the staff client on detail view: selects the 'Fines & Charges' tab by default, but appears as though it's selected the 'Checkouts' list. Whats the latest with this? I snuck the patch here into the 3.4.1 package updates. The jquery updates will eventually need to happen, but the patch here doesn't need to be worried about any more. Created attachment 9229 [details] [review] Bug 5184 - Upgrade jQuery to the latest version Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Created attachment 9232 [details] [review] Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. I'm testing a patch for the staff client and have taken care of the examples of the above syntax changes. Julian, did you say you had tested a jQuery upgrade in the staff client before? Do you remember what bugs you ran into? Created attachment 9235 [details] [review] Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. A patch for the staff client is attached in case anyone is eager to get started testing. I've done only limited testing so far but will do more. Created attachment 9285 [details] [review] [SIGNED-OFF] Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Created attachment 9286 [details] [review] [SIGNED-OFF] Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> I checked through various parts paying more attention to the cataloging module and did not scare up any errors. I'm signing off because this really needs to be pushed on up so that we have the full release cycle to fully debug. The latest version appears to be 1.8.19, so I wonder if we need top update these patches to reflect that? That's jQueryUI's version. Created attachment 9356 [details] [review] Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mason James <mtj@kohaaloha.com> Created attachment 9357 [details] [review] Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Created attachment 9358 [details] [review] Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mason James <mtj@kohaaloha.com> QA Comment: Good news :) Changelog from v1.3 is available here: http://webscripts.softpedia.com/scriptViewChangelog/jQuery-Javascript-Library-Changelog-39111.html A lot of functions are very useful. Marked as Passed QA Why are there duplicate patches for the staff client and why did the OPAC patch get obsoleted? There should be two patches: one for the staff client and one for the OPAC. It looks like Mason may have mistakenly attached the signed-off patch for staff twice. Comment on attachment 9358 [details] [review] Bug 5184 - Upgrade jQuery to the latest version (staff client) removing (duplicated) patch Patch pushed, and mail sent to koha-devel to warn for this major upgrade of jquery I missed to unobsolete the OPAC patch, and pushed it. Thx kf for pointing my mistake. OPAC patch pushed (tiny patch, passed QA) Reopened for new version (1.8.0). A separate bug has been created for the upgrade to 1.10.3, Bug 11570. |