Summary: | MARC21 field 545 missing | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins <camins> |
Component: | MARC Bibliographic data support | Assignee: | Jared Camins-Esakov (do not use) <koha> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, jcamins, koha.sekjal, koha, magnus, nengard, paul.poulain |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
follow up patch for it-IT and sample frameworks Add MARC21 field 545 to to framework fix bug 5226 Bug 5226: Follow up to new/awaiting_qa/bug_5226 Bug 5226: Add 545 to es-ES and nb-NO Signed patch for es and nb [3.4.x] Bug 5226: Add 545 to es-ES and nb-NO |
Description
Jared Camins
2010-09-15 19:02:32 UTC
It looks like the line declaring the field is missing from marc21_framework_DEFAULT.sql. The following line should be included around line 348: ('545', 'BIOGRAPHICAL OR HISTORICAL DATA', 'BIOGRAPHICAL OR HISTORICAL DATA', 1, 0, NULL, ''), Created attachment 2727 [details] [review] Proposed patch Pushed to new/awaiting_qa/bug_5266 Created attachment 2812 [details] [review] follow up patch for it-IT and sample frameworks This patch adds the field definition to - it-IT (default and sample frameworks) - de-DE, en, fr-FR, pl-PL (sample frameworks) I am not sure about the database update. If we want to do that, it should perhaps update all frameworks and languages. At the moment only en and de-DE default frameworks are updated. Follow up patch pushed to new/awaiting_qa/bug_5266 This bug is mentioned in: Add MARC21 field 545 to to framework fix bug 5226 http://lists.koha-community.org/pipermail/koha-patches/2010-November/012827.html Add MARC21 field 545 to to framework fix bug 5226 http://lists.koha-community.org/pipermail/koha-patches/2010-November/012828.html Add MARC21 field 545 to to framework fix bug 5226 http://lists.koha-community.org/pipermail/koha-patches/2010-November/012829.html This bug is mentioned in: Bug 5226: Follow up to new/awaiting_qa/bug_5226 http://lists.koha-community.org/pipermail/koha-patches/2010-December/013189.html Unless I misunderstand, this patch and its follow up are still missing signoff. They can be found under origin/new/awaiting_qa/bug_5226 (or just from Bugzilla). If you pick them from here, please rebase first. QA will follow signoff. Created attachment 6645 [details] [review] Add MARC21 field 545 to to framework fix bug 5226 Adds MARC21 field 545 to the English, French, German, and Polish MARC21 frameworks. The labels for the field still need to be translated into French and Polish. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 6647 [details] [review] Bug 5226: Follow up to new/awaiting_qa/bug_5226 This patch adds the field definition to - it-IT (default and sample frameworks) - de-DE, en, fr-FR, pl-PL (sample frameworks) I am not sure about the database update. If we want to do that, it should perhaps update all frameworks and languages. At the moment only en and de-DE default frameworks are updated. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed off patches attached QA Comment: Patches look good. Updating patch status. Only point of consideration: We apparently still need a follow up for es-ES (Spanish) and nb-NO (Norwegian). Could you send that too? Created attachment 7093 [details] [review] Bug 5226: Add 545 to es-ES and nb-NO Since the original patches for bug 5226 were submitted, two new translations have been added to Koha: es-ES and nb-NO. This patch adds the missing 545 line to the frameworks for those languages. Created attachment 7094 [details] [review] Signed patch for es and nb Paul: Last follow up is fine for me too. QA comment: tested that there is no impact on UNIMARC setups patch pushed, please test Depends on commit commit 7af27271272d11872ced646f2a1f72616095b56d This patch does not apply cleanly to 3.4.x. This is probably due to the previously mentioned dependency patch not applying cleanly either. Please rebase both patches and attach new ones. Created attachment 7265 [details] [review] [3.4.x] Bug 5226: Add 545 to es-ES and nb-NO Since the original patches for bug 5226 were submitted, two new translations have been added to Koha: es-ES and nb-NO. This patch adds the missing 545 line to the frameworks for those languages. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to 3.4.x. Please test and close. |