Summary: | Text does not wrap properly on labels | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Nighswonger <cnighswonger> |
Component: | Label/patron card printing | Assignee: | Chris Nighswonger <cnighswonger> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Chris Nighswonger
2010-09-23 19:53:59 UTC
The apparent fix is to have the text wrap alogrithm to calculate based on a label width reduced by approx. 3/16" when there is no left text margin. This is probably not the proper fix as it appears that this algorithm is being affected by adjustments in the label width for label creep and perhaps offset as well. But this does fix the symptom and is all the time available for this problem at present. Documentation Changes: It might be good to add a note to the effect that if the user does not supply a left text margin in the layout, a 3/16" (13.5 point) left text margin will apply by default. The patch is available here: http://git.koha-community.org/gitweb/?p=wip/koha-fbc.git;a=commit;h=7ac26f73f41fe17acd896d09f76b5d146de25495 Has this been pushed already? When I tried to test it I got the following: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5247 - Text does not wrap properly on labels Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Creators/Layout.pm No changes -- Patch already applied. nengard@debian:~/kohaclone$ Either the patch fails to apply or it has already been pushed. (In reply to comment #2) > Has this been pushed already? When I tried to test it I got the following: > > > Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y > Applying: Bug 5247 - Text does not wrap properly on labels > Using index info to reconstruct a base tree... > Falling back to patching base and 3-way merge... > Auto-merging C4/Creators/Layout.pm > No changes -- Patch already applied. > nengard@debian:~/kohaclone$ > > > Either the patch fails to apply or it has already been pushed. It was applied to master on 2010/09/24... http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=7ac26f73f41fe17acd896d09f76b5d146de25495 So... I'm marking this as Patch Pushed, Resolved, Fixed since it does fix the reported problem. |