Summary: | "Check in" then "Renew" checkboxes checked in the same time | ||
---|---|---|---|
Product: | Koha | Reporter: | Brice Sanchez <brice.sanchez> |
Component: | Circulation | Assignee: | Brice Sanchez <brice.sanchez> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, gmcharlt, wizzyrea |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
"Check in" then "Renew" checkboxes checked in the same time
Fix for bug 5281 Proposed alterantive fix |
I have a patch ! Created attachment 2680 [details] [review] Fix for bug 5281 I found that this patch didn't help instances where the librarian has used the "override renewal limit" option. (In reply to comment #3) > I found that this patch didn't help instances where the librarian has used the > "override renewal limit" option. I'm sorry but i don't understand what you mean. My patch is just a JS fix. > I'm sorry but i don't understand what you mean. My patch is just a JS fix.
Yes, and the behavior I'm seeing is tied to JS. If the patron has checkouts which have been renewed too many times or they have checkouts which are on hold for someone else the renewal checkbox will be hidden. The staff user has the option of checking the "override" checkbox at the bottom of the table to override the renewal limit. When this is done the renew/check in checkboxes show the old buggy behavior.
(In reply to comment #5) > > I'm sorry but i don't understand what you mean. My patch is just a JS fix. > > Yes, and the behavior I'm seeing is tied to JS. If the patron has checkouts > which have been renewed too many times or they have checkouts which are on hold > for someone else the renewal checkbox will be hidden. The staff user has the > option of checking the "override" checkbox at the bottom of the table to > override the renewal limit. When this is done the renew/check in checkboxes > show the old buggy behavior. Ok, I see. This is the javascript that handles the clicks on the TD who is not working properly, it could be turned off !? Created attachment 2690 [details] [review] Proposed alterantive fix This fix corrects the behavior of the checkboxes whether the user clicks the checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome, Safari 5, and IE 8. Signed off and resubmitted. Applies to current HEAD. Patch pushed please test and close This bug is mentioned in: Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time http://lists.koha-community.org/pipermail/koha-patches/2010-November/012946.html I confirm that the buggy behavior has been eradicated both with and without the override checkbox checked. |
Created attachment 2667 [details] "Check in" then "Renew" checkboxes checked in the same time In "Home › Circulation › Checkouts › briceSanc" . I'm unable to check "Renew" then "Check in" in the same time (i think its normal) but i'm able to check "Check in" then "Renew". I'm speaking about the checkboxes in the 'Checkout(s)' html table