| Summary: | Google Preview Option for OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Darrell Ulm <darrellulm> |
| Component: | OPAC | Assignee: | Darrell Ulm <darrellulm> |
| Status: | NEW --- | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | chris, dpavlin, jwagner, kyle.m.hall |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
patch
Bug 5292 - Google Preview Option for OPAC |
||
|
Description
Darrell Ulm
2010-10-07 18:59:45 UTC
OK, Patch for new enhancement sent. Thanks! Darrell Ulm Darrell, Where did you send the patch to? I don't see it on the public list or attached here. Nicole (In reply to comment #2) > Darrell, > > Where did you send the patch to? I don't see it on the public list or attached > here. > > Nicole Hi Nicole. I sent it and tested my git send-email on my own account. It was sent to me. Is koha-patches@lists.koha-community.org receiving? Darrell I don't see any patches from you in the patches mailing list - is it possible that you're not registered with the list? I know that was the problem I had the first few patches I thought I sent - they weren't received cause I wasn't a registered user on the list. (In reply to comment #2) > Darrell, > > Where did you send the patch to? I don't see it on the public list or attached > here. > > Nicole Hi Nicole. I sent it and tested my git send-email on my own account. It was sent to me. Is koha-patches@lists.koha-community.org receiving? Darrell(In reply to comment #4) > I don't see any patches from you in the patches mailing list - is it possible > that you're not registered with the list? I know that was the problem I had the > first few patches I thought I sent - they weren't received cause I wasn't a > registered user on the list. Nicole, OK, well I had better register then. I guess a few patches have been missed. -Darrell (In reply to comment #4) > I don't see any patches from you in the patches mailing list - is it possible > that you're not registered with the list? I know that was the problem I had the > first few patches I thought I sent - they weren't received cause I wasn't a > registered user on the list. Nicole, Actually I checked. I am registered and have been. I don't know why it is bouncing. It works when I git send-email to myself. I suppose other patches were missed. I have been sending them, but I assume they collected in an email somewhere. Weird. I wonder how this can be solved? Any ideas? -Darrell This bug is mentioned in: Bug 5292 Google Preview Option for OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-October/012658.html Bug 5292 Google Preview Option for OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-October/012661.html Bug 5292 Google Preview Option for OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-October/012664.html Bug 5292 Google Preview Option for OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-October/012668.html Created attachment 2868 [details] [review] patch The patch doesn't apply - and it also doesn't have a way to add the preference if you are upgrading (need to update updatedatabase.pl - unless I missed it) Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5292 Google Preview Option for OPAC .dotest/patch:42: trailing whitespace. .dotest/patch:51: trailing whitespace. error: patch failed: installer/data/mysql/en/mandatory/sysprefs.sql:286 error: installer/data/mysql/en/mandatory/sysprefs.sql: patch does not apply Using index info to reconstruct a base tree... <stdin>:42: trailing whitespace. <stdin>:51: trailing whitespace. warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merged installer/data/mysql/en/mandatory/sysprefs.sql Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl Auto-merged opac/opac-detail.pl nengard@debian:~/kohaclone$ (In reply to comment #10) > The patch doesn't apply - and it also doesn't have a way to add the preference > if you are upgrading (need to update updatedatabase.pl - unless I missed it) > Yes, I should re-base. I don't think it all got in there. Need to do this next year because of other responsibilities unfortunately. Created attachment 10010 [details] [review] Bug 5292 - Google Preview Option for OPAC Adds option to insert link for Google Books preview into opac for items with available preview. Patch based on original work by Darrel Ulm. Excuse my ignorance, but in current master we already have Google preview link when using google book covers. Why do we need another implementation of it? (In reply to comment #13) > Excuse my ignorance, but in current master we already have Google preview > link when using google book covers. Why do we need another implementation of > it? The link we have now opens a new tab/window to the Google Books page. This patch tried to implement this feature for opening an embedded preview within the OPAC: https://developers.google.com/books/docs/preview-wizard |