Bug 5394

Summary: Fatal error when searching for a non-existant item when receiving an order
Product: Koha Reporter: MJ Ray (software.coop) <mjr>
Component: AcquisitionsAssignee: Henri-Damien LAURENT <henridamien>
Status: CLOSED WONTFIX QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: katrin.fischer
Version: rel_3_0   
Hardware: All   
OS: All   
URL: http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?supplierid=4&freight=0&invoice=2117008&receive=9781563636783
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description MJ Ray (software.coop) 2010-11-12 16:45:32 UTC
A book is a new edition of the title in the catalogue, but their 
records are, and should remain, completely unrelated.

I couldn't see a record for it in the acquisition module so I 
searched for it by ISBN from here:
http://localhost:8080/cgi-bin/koha/acqui/parcel.pl?type=intra&supplierid=4&datereceived=2010-10-14&invoice=2117008
under "search orders to add to this shipment"
to check that the new edition record wasn't tucked away somewhere.

I got the error message "Can't use string ("0") as a HASH ref while "strict refs" in use at /usr/local/share/koha/cgi-bin/acqui/orderreceive.pl line 192."

This appears to be because the end of acqui/orderreceive.pl doesn't check whether the earlier GetBookSellerFromId actually found anything.

I will prepare a simple patch.  I think this is 3.0.x only.
Comment 1 MJ Ray (software.coop) 2010-11-12 18:29:02 UTC
The following changes since commit dc7e0ecba7cd256ffab014ff6f6f658eaf561fb4:
  MJ Ray (1):
        [Bug 5394] Handle situation where bookseller is not found

are available in the git repository at:

  git at gitorious.org:koha/mainline.git for-3.0/bug_5394

Taken from
http://lists.koha-community.org/pipermail/koha-patches/2010-November/012939.html
Comment 2 Katrin Fischer 2013-03-24 18:11:03 UTC
3.0.x is no longer maintained, so I will mark this as WONTFIX.