Summary: | C4::Koha::DisplayISBN should be wrapper for Business::ISBN->as_string | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, colin.campbell, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Galen Charlton
2010-11-14 03:17:49 UTC
Actually the only place where DisplayISBN is used is in C4/Biblio to retrieve a publisher code. Therefore the routine (which did generate some oddly formatted iscns!) could be removed if Biblio uses Business::ISBN directly Actually The calling routine GetPublisherNameFromIsbn is not used either. Sent patch to remove both routines This bug is mentioned in: Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn http://lists.koha-community.org/pipermail/koha-patches/2010-December/013268.html Pushed, please test NOTE this will break some unit tests, that is ok, I have purposefully done so so that I can use it for a teaching tool with my students tomorrow. |