Bug 5408

Summary: Refactor C4::Circulation::GetIssuingRule
Product: Koha Reporter: Clay Fouts <cfouts>
Component: Architecture, internals, and plumbingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED WONTFIX QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: P5 - low CC: chris
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Patch to refactor GetIssuingRule

Description Clay Fouts 2010-11-15 06:44:13 UTC
GetIssuingRule submits a cascade of queries to the database to find its match. This could be optimized and cleaned up by retrieving them all at once.
Comment 1 Clay Fouts 2010-11-15 08:23:46 UTC
Created attachment 2752 [details]
Patch to refactor GetIssuingRule
Comment 3 Owen Leonard 2012-08-22 19:52:49 UTC
Is this bug still valid? I assume the patch will never be rebased by the original author.
Comment 4 Chris Cormack 2012-08-22 20:57:18 UTC
(In reply to comment #3)
> Is this bug still valid? I assume the patch will never be rebased by the
> original author.

Unlikely I agree, should we close this?
Comment 5 Clay Fouts 2012-08-23 16:09:41 UTC
If you refer to the mailing list comments linked from here, I was told that Biblibre's approach to optimizing this section was being preferred over mine. Surprising that in two year's time neither my code nor theirs has actually been adopted to treat this poorly constructed functionality.
Comment 6 Katrin Fischer 2014-11-02 09:42:03 UTC
WONTFIXING this approach as Koha has changed quite a bit since 2010...