Description
Koustubha Kale
2010-11-18 06:21:04 UTC
Created attachment 2770 [details] [review] Patch adds a new itemBarcodeInputFilter for libsuite8 style barcodes This patch emulates the functionality of Libsuite8 software of converting the scanned barcode into one stored in Koha using the itemBarcodeInputFilter system preference. To use this new itemBarcodeInputFilter systempreference choice called 'libsuite8', the barcodes stored in Koha must match the pattern of <branchcode>-<itemtype_code>-<accession_number>. This is easy to achieve while doing retrospective conversion from Libsuite8 to Koha. As expected the itemBarcodeInputFilter will return unmodified barcode is presented with a barcode of pattern <branchcode>-<itemtype_code>-<accession_number> The perl code in C4/Circulation.pm is ugly and NEEDS major code cleanup. All help is much appreciated.. Created attachment 2772 [details] [review] Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes Revised the patch to reduce perl code with some regex Created attachment 2779 [details] [review] This revision eliminates the need to change circ/circulation.pl as was the case in the earlier patch. Created attachment 2780 [details] [review] This revision adds a test to t/Circulation_barcodedecode.t Created attachment 2799 [details] [review] This revision adds conversion support for some libsuite8 barcodes which are only numbers. i.e. these barcodes dont start with item type. e.g. 0002245 or 472. This revision adds conversion support for some libsuite8 barcodes which are only numbers. i.e. these barcodes dont start with item type. e.g. 0002245 or 472. In libsuite8 such barcodes are assumed to be of type book with associated item type code 'b'. Tests for same have also been added to t/Circulation_barcodedecode.t Created attachment 2820 [details] [review] Rev-5 patch new itemBarcodeInputFilter for libsuite8 style barcodes This revision corrects the way updatedatabase.pl is changed in order to correctly update version and insert the libsuite8 option in the database. Also kohaversion.pl is changed in the recommended format of 3.0X.0X.XXX to reflect database has changed. This revision also changes the erroneous itemBarcodeInputFilter description in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref from 'scanned patron barcodes' to 'scanned item barcodes' there by eliminating need for a separate patch for bug 5417. Requesting for test and sign off. I tested the functionality and signed-off. This bug is mentioned in: Bug 5418: Add a new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013060.html Bug 5418: Add a new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013077.html Bug 5418: Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013066.html Bug 5418: Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013078.html Bug 5418: Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013080.html Bug 5418: Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013081.html Bug 5418: Revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013082.html Bug 5418: Re-revised patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013086.html Bug 5418: Rev-3 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-November/013087.html Created attachment 2903 [details] [review] Follow up adding the new option to translated sql files This bug is mentioned in: Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013161.html Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013165.html Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013166.html Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013181.html Bug 5418: Rev-5 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013212.html Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013188.html Bug 5418: Rev-5 patch new itemBarcodeInputFilter for libsuite8 style barcodes http://lists.koha-community.org/pipermail/koha-patches/2010-December/013206.html Bug 5418: Follow up - adding new option to translated sql files http://lists.koha-community.org/pipermail/koha-patches/2010-December/013459.html Follow up fixing translated sql files still needs sign-off. Didn't find the secondpatch on current master, first patch introducing the feature was pushed. Follow up patch does not apply Created attachment 4308 [details] [review] Follow-up patch redone Created attachment 4394 [details] [review] Bug 5418: Follow up fix for translated sys pref sql files Add 'libsuite8' as new option to system preference 'itemBarcodeInputFilter' en and nb-NO files are already correct. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Original patch is in master already, follow up patch pushed. There have been no further reports of problems so I am marking this bug resolved. |