|
Description
Zachary Spalding
2010-11-23 18:30:05 UTC
Confirmed as a most useful timesaver by our cataloguers (3.8.5). -- Paul There is a nice workaround: - From Search results or detail display, add items to your cart - Open cart and make use of "Batch delete" *** Bug 3005 has been marked as a duplicate of this bug. *** Bug 3005 asked for a success message on deleting a record. Could we imagine to factor this wish in here somehow? Maybe we could display a modal and let the user decide where they want to go after successful deletion? Or display a success message on the page we redirect to. Created attachment 107753 [details] [review] Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list (In reply to Jonathan Druart from comment #5) > - Delete the record > => You are back to the adv search form but we new link "Go back to the > results" is present at the top of the page I'm not seeing the 'Go back to the results' link anywhere on the advanced search page after applying this patch and following the above step. Created attachment 107866 [details] [review] Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list Created attachment 107868 [details] [review] Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This now works as described so I'm signing off.. However, I wonder if it might be nicer reverse the logic and redirect back to the search results by default instead of redirected to advanced search and displaying a button to get to the prior results... Created attachment 107933 [details] [review] Bug 5428: Jump back to the search result after deleting a record This patch adds the ability to jump back to the search result after a record has been deleted. Also it keeps the "browser" when all items are deleted from a bibliographic record Test plan: - Start a new search - Select a record with items - Delete all the items => You still see the browser - Delete the record => You are back to the adv search form but we new link "Go back to the results" is present at the top of the page Limitation: As we delete the record we do not longer know the offset, we are back to the first page of the result list Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 107934 [details] [review] Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch Signed-off-by: Nick Clemens <nick@bywatersolutions.com> (In reply to Martin Renvoize from comment #9) > This now works as described so I'm signing off.. > > However, I wonder if it might be nicer reverse the logic and redirect back > to the search results by default instead of redirected to advanced search > and displaying a button to get to the prior results... I agree, it sent me down a path of adding this in other places, but I think we should file a new bug. If my follow-up looks good I am of the mindset to call this one a good enhancement after 10 years of waiting, and to do further enhancements on the next one. Nick, your patch does not work for me, can you double check? searchid is not passed the batchMod.pl (In reply to Jonathan Druart from comment #13) > Nick, your patch does not work for me, can you double check? > > searchid is not passed the batchMod.pl it works for me the links don't have searchid, however, there is js that adds it when you use the links in the Edit dropdown Nick, please provide a test plan for this last patch. What I am doing: Do a search select a record select items in the holdings table, click "Modify selected items" I am on /tools/batchMod.pl?op=show&itemnumber=37&itemnumber=36&biblionumber=14&src=CATALOGUING (not that searchid is missing) click save => https://snipboard.io/lKhRQa.jpg None of the 2 "Return to the record link" has the searchid None of the 2 links redirect me to the detail view with the browser. Created attachment 108096 [details] [review] Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch To test: 0 - Perform a search in the staff client 1 - Click a title to go to the details page for a record 2 - Click the 'Edit' button and select 'Edit items in a batch' 3 - Note the searchid is in the url 4 - Make a change and hit 'Save' 5 - Note the 'Return the the record' link at the top, and the button on the bottom include searchid in URL 6 - Click one and note the brwoser is stil there 7 - Click 'Edit' and select 'Delete items in a batch' 8 - Delete one item 9 - Click return to record 10 - Browser is there 11 - Click 'Delete items in a batch again 12 - Select all and check 'Delete records if no items remain' 13 - Delete them 14 - Note you have a link to 'Go back to the results' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 108099 [details] [review] Bug 5428: Add searchid to the "Return to the record" button (batch del) Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x the link 'Go back to the results' has disappeared at least up to 22.11.06.005 (maybe some changes in the js or the dom) (In reply to Mark Hofstetter from comment #20) > the link 'Go back to the results' has disappeared at least up to > 22.11.06.005 (maybe some changes in the js or the dom) Hi Mark, please open a new bug and use the depends on to link to this one. Once something has been released, we always need a new bug for the patches. Closing the bug again as bug 34506 has been filed. |
