Summary: | Allow currency to be set during order creation | ||
---|---|---|---|
Product: | Koha | Reporter: | Savitra Sirohi <savitra.sirohi> |
Component: | Acquisitions | Assignee: | Henri-Damien LAURENT <henridamien> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, colin.campbell, julian.maurice, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch against master, introduces currency drop down list in order screen
Path to default order currency to that in vendor record Original patch rebased Rebased patch |
Description
Savitra Sirohi
2010-12-02 15:13:01 UTC
Hi, can you please attach the patch file to the bug? It makes testing a lot easier for me. Thank you! Created attachment 2800 [details] [review] Patch against master, introduces currency drop down list in order screen There is a flaw in the patch. When creating a new order the vendor currency is ignored and the user has to select it. This is probably not what the user wants in almost all cases. Will attach a patch rectifying this. Created attachment 2826 [details] [review] Path to default order currency to that in vendor record Would need to set a default currency from vendor (or active currency) on new orders. this patch adds to the earlier one to do that. This bug is mentioned in: Acquisitions - ability to set currency in order screens - Bug 5466 http://lists.koha-community.org/pipermail/koha-patches/2010-December/013147.html Patch does not apply. -- Applying: Acquisitions - ability to set currency in order screens /home/julian/koha/versions/koha-community-git/.git/rebase-apply/patch:22: trailing whitespace. error: patch failed: acqui/basket.pl:217 error: acqui/basket.pl: patch does not apply Patch failed at 0001 Acquisitions - ability to set currency in order screens Created attachment 3349 [details] [review] Original patch rebased Created attachment 3350 [details] [review] Rebased patch I've rebased both the original patch and my subsequent fix against current master Pushed, please test |