Bug 5522

Summary: The 'open in new window' setting should apply to google preview and ebook links
Product: Koha Reporter: Robin Sheat <robin>
Component: OPACAssignee: Robin Sheat <robin>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: chris, nengard
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Proposed patch

Description Robin Sheat 2010-12-19 23:44:42 UTC
It doesn't seem to be working at the moment.
Comment 1 Robin Sheat 2010-12-19 23:46:23 UTC
I take that back, it does work for ebooks. Not for google preview, though. Will have to see if this is possible.
Comment 2 Robin Sheat 2010-12-20 02:03:14 UTC
Created attachment 2885 [details] [review]
Proposed patch
Comment 3 Nicole C. Engard 2010-12-20 12:34:56 UTC
I have fixed the whitespace errors and signed off - I hope I did that edits right :)
Comment 4 Chris Cormack 2010-12-21 01:35:06 UTC
Pushed please test
Comment 5 MJ Ray (software.coop) 2011-01-11 12:58:03 UTC
This bug is mentioned in:
Bug 5522 - allow google preview	to open in a new window http://lists.koha-community.org/pipermail/koha-patches/2010-December/013432.html
Bug 5522 - allow google preview to open in a	new window http://lists.koha-community.org/pipermail/koha-patches/2010-December/013427.html