Summary: | SIP Due dates miscalculated via DateTime | ||
---|---|---|---|
Product: | Koha | Reporter: | Joe Atzberger <ohiocore> |
Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 29410 |
Description
Joe Atzberger
2011-01-09 17:20:45 UTC
Actually there is no need to process duedate here as a datetime value at all as it is never manipulated as such its just the iso format string from the db. We should pass as is but reformat as required as in checkout. (If we were to need to do so we should provide a DateTime::TimeZone initialized to local in case TZ is not set.) The date processing was a bit messy all told. ILS/Item.pm did all the manipulation as well then immediately overwrote the result with the string it had just deconstructed. Removed ILS/Item.pm and Sip.pm's dependencies on DateTime. Second patch sent which adds test for Sip::timestamp's output with iso-strings, time_t secs and no params (i.e. now) (In reply to comment #2) > Second patch sent which adds test for Sip::timestamp's output with iso-strings, > time_t secs and no params (i.e. now) Sorry to say, I already drafted a patch for this that just uses DateTime correctly. I support removing it as a dependency, but there is more work to take it off the list of required modules, pull it from INSTALL docs, etc. I don't think I agree with artificially seeding the due date time with 23:59. That's not helpful, imho. Also, we should increment $VERSION for as many touches as are going in. This bug is mentioned in: Bug 5601 Fix processing of DueDate return http://lists.koha-community.org/pipermail/koha-patches/2011-January/013580.html Bug 5601 :: Add tests for bugfix http://lists.koha-community.org/pipermail/koha-patches/2011-January/013581.html Bug 5601 Fix processing of DueDate return http://lists.koha-community.org/pipermail/koha-patches/2011-January/013583.html Bug 5601 :: Add tests for bugfix http://lists.koha-community.org/pipermail/koha-patches/2011-January/013582.html Bug 5601 Fix processing of DueDate return http://lists.koha-community.org/pipermail/koha-patches/2011-January/013584.html Bug 5601 :: Add tests for bugfix http://lists.koha-community.org/pipermail/koha-patches/2011-January/013585.html The submitted patch was signed off and pushed to master in Feb. Updating status to reflect that There have been no further reports of problems so I am marking this bug resolved. |