Summary: | Change wording on review.tmpl from white/blacklists to approved/rejected | ||
---|---|---|---|
Product: | Koha | Reporter: | David Schuster <dschust1> |
Component: | Staff interface | Assignee: | David Schuster <dschust1> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, dschust1, gmcharlt, nengard |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
patch to change the wording on review.tmpl
Missed "Test blacklist" in the first patch sorry. |
Description
David Schuster
2011-01-22 03:52:37 UTC
Created attachment 3028 [details] [review] patch to change the wording on review.tmpl Please note that a bug cannot be marked "fixed" until the patch has been submitted, the patch is signed off on, the patch has been pushed to master, and the patch is tested. This patch needs a correction: it only corrects one of two instances of the term "blacklist." Owen, I did a search on the page and didn't find another one - where was it? I wouldn't have signed off if I had found it. Sorry about that. Nicole > I did a search on the page and didn't find another one
The patch attached to this bug report doesn't correct this:
<h4>Test Blacklist</h4>
I didn't realize this got a signoff. I just saw it go from patch attached to "fixed," so I thought a step had been missed.
You were right, a step was skipped - it hadn't been pushed yet, but it had been signed off (I just didn't update the bug report - my bad). I'll wait for David to update his patch and gladly sign off again. Pushed please test Created attachment 3115 [details] [review] Missed "Test blacklist" in the first patch sorry. Sorry for the additional work. I couldn't figure out how to "amend" my original patch. Signed off on follow up Pushed, please test and mark resolved |