Bug 5765

Summary: patron messaging form template tests for SMS inconsistently
Product: Koha Reporter: Ian Walls <koha.sekjal>
Component: PatronsAssignee: Kyle M Hall <kyle.m.hall>
Status: CLOSED WORKSFORME QA Contact: Bugs List <koha-bugs>
Severity: trivial    
Priority: P5 - low CC: costalc, gmcharlt, katrin.fischer, koha.sekjal
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Ian Walls 2011-02-16 02:18:54 UTC
For the header row of the table, the test is performed on whether SMSSendDriver is defined, but for each row, the first test is on whether 'transport_sms' is defined for that notice, then whether the driver exists.  If an sms transport is defined for a notice (or even if the thinks it is), this will add an extra column of '--' to the table, forcing everything over by one, and the 'do not notify' column off the table.

Reversing the order of the <TMPL_IF>'s in the messaging_preference_form.inc should resolve this.
Comment 1 Owen Leonard 2011-02-24 15:25:30 UTC
*** Bug 5808 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2011-02-24 15:27:59 UTC
According to Bug 5809 this problem exists in the OPAC as well.
Comment 3 Owen Leonard 2011-02-24 15:28:11 UTC
*** Bug 5809 has been marked as a duplicate of this bug. ***
Comment 4 Owen Leonard 2013-03-26 16:07:04 UTC
Is this bug still valid in master? I can't tell from the description how to try to reproduce it.
Comment 5 Katrin Fischer 2014-11-02 11:50:28 UTC
Bug report is pretty old and we have done quite some work on this since. Closing WORKSFORME.