Bug 5806

Summary:	Search results display items for all locations when the SearchMyLibrary first system pref is activated
Product:	Koha	Reporter:	Peter Lorimer <peter.lorimer>
Component:	OPAC	Assignee:	Peter Lorimer <peter.lorimer>
Status:	Failed QA ---	QA Contact:	Bugs List <koha-bugs>
Severity:	enhancement
Priority:	P5 - low	CC:	chris, colin.campbell, jwagner, veron
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055
Change sponsored?:	Sponsored	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Patch File for this Bug

Description Peter Lorimer 2011-02-23 16:47:29 UTC

When searchMyLibraryFirst system pref is activated, although the results are filtered, the search results show items available in all locations. On the detail page items from all locations are also being displayed.

A good enhancement would be an additional pref called SearchMyLibraryOnly where as well as the results, the detail summaries and the locations the item is available (in the search result content) are also filtered. 

A user should have the ability to choose a library to search or to log in, when the user logs in that users library is selected, other wise the user can select a library or opt to search all libraries

If you choose SearchMyLibraryOnly you should only see items from tha selected library and nothing else.

Comment 1 Katrin Fischer 2011-08-30 13:37:41 UTC

Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch attached and I don't see one on the mailing list. Please feel free to attach your patch and change it back.

Comment 2 Peter Lorimer 2011-08-31 10:10:39 UTC

Created attachment 5237 [details] [review]
Patch File for this Bug

Comment 3 Peter Lorimer 2011-08-31 10:11:07 UTC

Needs Signoff

Comment 4 Peter Lorimer 2011-08-31 10:12:59 UTC

Needs Signoff(In reply to comment #1)
> Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch
> attached and I don't see one on the mailing list. Please feel free to attach
> your patch and change it back.


Hi Katrin

I've attached the patch

Comment 5 Katrin Fischer 2011-08-31 10:16:06 UTC

Hi Peter, 
only another hint: To set this bug to 'Needs Signoff' change the 'Importance' to 'PATCH-Sent'. By doing that the 'Patch Status' pull down appears and you can select 'Needs Signoff' there. As you have provided a patch for this bug you should also change 'Assigned To' to be your bugzilla account's email address.

Comment 6 Paul Poulain 2011-09-27 16:43:44 UTC

I don't have tested the patch, but I mark is "failed QA" because it seems there are many things that are not related to the goal of the patch.

Just 3 examples :

    ModBiblioframework($biblionumber,$frameworkcode);
@@ -2730,7 +2732,10 @@ sub EmbedItemsInMarcBiblio {
         my $item_marc = C4::Items::GetMarcItem($biblionumber, $itemnumber);
         push @item_fields, $item_marc->field($itemtag);
     }
-    $marc->insert_fields_ordered(@item_fields);
+        if (defined $marc)
+        {
+             $marc->insert_fields_ordered(@item_fields);
+        }   
 }

and 
 sub z3950_search_args {
     my $bibrec = shift;
-    $bibrec = { title => $bibrec } if !ref $bibrec;
+  
+ 
+    if (validate_isbn($bibrec) == 1)
+    {
+    $bibrec = { isbn => $bibrec } if !ref $bibrec;
+}
+else {
+     $bibrec = { title => $bibrec } if !ref $bibrec;
+}

and a new index.htm file:
diff --git a/index.htm b/index.htm
new file mode 100755
index 0000000..30a4b1e
--- /dev/null
+++ b/index.htm
@@ -0,0 +1,131 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
+  <head>
+    <title>Scooter Online Library System</title>
+ 
+    <meta name="MSSmartTagsPreventParsing" content="true" />
+    <link id="theme" rel="stylesheet" type="text/css" href="style.css" title="theme" />
+<script type="text/javascript" language="javascript" src="js/addon.js"></script>
+<script type="text/javascript" language="javascript" src="js/custom.js"></script>
+  </head>
+  <body bgcolor="#E0E0E"> 
+    <!-- top wrapper -->  
+   
+      <div id="topSlideshowWrapper"> 
+        <div id="sliderContainer">

Comment 7 Marc Véron 2016-08-23 07:39:16 UTC

Is this bug still valid?