| Summary: | Search results display items for all locations when the SearchMyLibrary first system pref is activated | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Peter Lorimer <peter.lorimer> |
| Component: | OPAC | Assignee: | Peter Lorimer <peter.lorimer> |
| Status: | Failed QA --- | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | chris, colin.campbell, jwagner, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Patch File for this Bug | ||
|
Description
Peter Lorimer
2011-02-23 16:47:29 UTC
Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch attached and I don't see one on the mailing list. Please feel free to attach your patch and change it back. Created attachment 5237 [details] [review] Patch File for this Bug Needs Signoff Needs Signoff(In reply to comment #1) > Hi Peter, I have removed the 'Needs Signoff' status, because there is no patch > attached and I don't see one on the mailing list. Please feel free to attach > your patch and change it back. Hi Katrin I've attached the patch Hi Peter, only another hint: To set this bug to 'Needs Signoff' change the 'Importance' to 'PATCH-Sent'. By doing that the 'Patch Status' pull down appears and you can select 'Needs Signoff' there. As you have provided a patch for this bug you should also change 'Assigned To' to be your bugzilla account's email address. I don't have tested the patch, but I mark is "failed QA" because it seems there are many things that are not related to the goal of the patch.
Just 3 examples :
ModBiblioframework($biblionumber,$frameworkcode);
@@ -2730,7 +2732,10 @@ sub EmbedItemsInMarcBiblio {
my $item_marc = C4::Items::GetMarcItem($biblionumber, $itemnumber);
push @item_fields, $item_marc->field($itemtag);
}
- $marc->insert_fields_ordered(@item_fields);
+ if (defined $marc)
+ {
+ $marc->insert_fields_ordered(@item_fields);
+ }
}
and
sub z3950_search_args {
my $bibrec = shift;
- $bibrec = { title => $bibrec } if !ref $bibrec;
+
+
+ if (validate_isbn($bibrec) == 1)
+ {
+ $bibrec = { isbn => $bibrec } if !ref $bibrec;
+}
+else {
+ $bibrec = { title => $bibrec } if !ref $bibrec;
+}
and a new index.htm file:
diff --git a/index.htm b/index.htm
new file mode 100755
index 0000000..30a4b1e
--- /dev/null
+++ b/index.htm
@@ -0,0 +1,131 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
+ <head>
+ <title>Scooter Online Library System</title>
+
+ <meta name="MSSmartTagsPreventParsing" content="true" />
+ <link id="theme" rel="stylesheet" type="text/css" href="style.css" title="theme" />
+<script type="text/javascript" language="javascript" src="js/addon.js"></script>
+<script type="text/javascript" language="javascript" src="js/custom.js"></script>
+ </head>
+ <body bgcolor="#E0E0E">
+ <!-- top wrapper -->
+
+ <div id="topSlideshowWrapper">
+ <div id="sliderContainer">
Is this bug still valid? |