Summary: | No toolbar in record view when quotes present in title | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Cataloging | Assignee: | Janusz Kaczmarek <januszop> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice, koha.sekjal |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
A screenshot illustrating the problem
Proposed patch Another patch |
Created attachment 3236 [details] [review] Proposed patch This is a proposed workaround for the described problem. J. Created attachment 3237 [details] [review] Another patch Another possible fix inspired by Paul Poulain. J. Patch work for me. Signed off. Pushed please test and mark resolved |
Created attachment 3235 [details] A screenshot illustrating the problem If there are double quotes in title (but also if there were any in lccn, isbn, issn, author, dewey, subject) the nice toolbar with buttons (cattoolbar) in normal view and MARC view (in staff client) will not appear. Instead there is a text list of options (cf. screenshot). The reason is that the JavaScript function GetZ3950Terms called when constructing the buttons fails, which is because of additional quotes in strQuery. The reason for this is that the C4::Search::z3950_search_args function does not escape quotes. A simple workaround will be submitted shortly. Regards, Janusz