Summary: | opacstylesheet not loading on all pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, jcamins, mark.gavillet, ruth |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Proposed fix |
Description
Nicole C. Engard
2011-03-05 17:14:00 UTC
I see no problems with those pages when using the opacstylesheet preference. Can you test again? If it's still broken for you perhaps you could pass on the stylesheet for me to test with along with a description of what styles aren't showing up. I take back what I said before about not seeing it. It wasn't until I examined the logic of the template that I realized how the bug worked. The "opacstylesheet" variable isn't getting passed to the template on the login page. Unfortunately I don't understand why. The OPACUserCSS variable is working fine, for instance. What's different about opacstylesheet? This is probably a problem with C4::Auth. I will take a look at it. Regards, Jared Created attachment 3470 [details] [review] Proposed fix Jared is right, and I just wasn't looking in the right place in Auth.pm. There is a separate section in which template variables are declared for the login page. The opacstylesheet variable was missing from that section. too bad we're late on submitting our patches: i've fixed (with the same fix) on march 17th. So I confirm the problem and the fix (just in case = see branch am123/CRI/MT6039 on git.biblibre.com) Pushed, please test This bug is mentioned in: Fix for Bug 5833, opacstylesheet not loading on all pages http://lists.koha-community.org/pipermail/koha-patches/2011-March/014283.html Fix for Bug 5833, opacstylesheet not loading on all pages http://lists.koha-community.org/pipermail/koha-patches/2011-March/014281.html |