Summary: | Holds link missing when 942$c is not for loan | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, jcamins, jwagner, mark.gavillet, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/catalogue/search.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot
Proposed patch Signed-off patch |
Created attachment 3256 [details] [review] Proposed patch Adds check for sys pref item-level_itypes. I have applied this patch and my bib record is showing that it can be put on hold even after i change the system preference and have the bib set to a not for loan type and the item to a for loan type. I'm wondering if I tested wrong or if this has failed QA. Can someone else test. Hi Nicole, what were the settings you tested it with? Have you seen the comments on the patch file? Basically the aim is to make it ignore the 942$c when using item-level_itypes = speficic item. I followed the test parameters you put in the patch. I'll try it again later. Created attachment 3360 [details] [review] Signed-off patch Signed off on Katrin's patch. Note that this patch changes the Results display, not the Details display. Pushed, please test |
Created attachment 3255 [details] screenshot When 942$c is set to a not for loan itemtype, the holds link in staff search results is not shown, although item-level_itypes is set to 'specific item'. Instead of the hold link the result list shows 'No holds allowed', no matter which item types the attached items are.