Summary: | Routing slip not displaying publication date | ||
---|---|---|---|
Product: | Koha | Reporter: | Reed Wade <reed> |
Component: | Serials | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jcamins, koha.sekjal, kristina, magnus, paul.poulain, stephane.delaye |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
adds publication date to routing slip
routing list before patch New Patch Bug 5841: Routing slip not displaying publication date Bug 5841: Routing slip not displaying publication date [SIGNED-OFF] Bug 5841: Routing slip not displaying publication date |
Description
Reed Wade
2011-03-08 00:01:19 UTC
Created attachment 3260 [details] [review] adds publication date to routing slip This work sponsored by Opus. Created attachment 3266 [details]
routing list before patch
I'm confused about this patch because the attached shows that my routing slip does have a publication date on it ... what does this patch add? I applied the patch and didn't notice any difference.
The patch in its current form does not do anything. It passes extra parameters to a function which doesn't look at them and whose main function is to call a perl program, which reads the data for the slip. Is there something missing here? Created attachment 3649 [details] [review] New Patch Hold off testing for now; there's a possible change to this in the works This bug is mentioned in: Bug 5841 - routing slip not showing publication date http://lists.koha-community.org/pipermail/koha-patches/2011-March/014008.html The "Print list" links still don't print the publication date. The publication date is only printed, when using "Edit routing list" and printing the slip from the preview there. Created attachment 7786 [details] [review] Bug 5841: Routing slip not displaying publication date To test: Compare output of the 2 different links for printing routing lists. 1) Links in the table of issues on the serial collection page 2) Link following the steps from editing and saving a routing list Both previews should show the date now. I tried applying the patch in a sandbox but i have this message Applying: Bug 5841: Routing slip not displaying publication date Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Failed to merge in the changes. Patch failed at 0001 Bug 5841: Routing slip not displaying publication date When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Guess this should be set to "doesn't apply", then. Created attachment 8343 [details] [review] Bug 5841: Routing slip not displaying publication date To test: Compare output of the 2 different links for printing routing lists. 1) Links in the table of issues on the serial collection page 2) Link following the steps from editing and saving a routing list Both previews should show the date now. Rebased on current master and fixed the conflict - should be testable now :) Created attachment 8462 [details] [review] [SIGNED-OFF] Bug 5841: Routing slip not displaying publication date Tested as per Katrin's test scenario. Both pages show the same date. Assumption: "Publication date" means the "serialplanneddate" (found by Katrin) and not the date that the issue was published. Template only change to add serialplanneddate to routing slip. Marking Passed QA. This bug will be included in the Koha 3.6.5 release. |