| Summary: | Allow message names to be translatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, paul.poulain |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 5646, 26985 | ||
| Attachments: |
Proposed patch
Patch for 3.2.x proposed patch fixing variable names in multiple sample files Signed off patch |
||
|
Description
Julian Maurice
2011-03-17 09:39:41 UTC
Created attachment 3333 [details] [review] Proposed patch Pushed please test NOTE: Please remember to set the statuses, it means it's far less likely for me to miss seeing a patch ready to be tested and merged Created attachment 3413 [details] [review] Patch for 3.2.x Some of the trnaslat Created attachment 3999 [details] [review] proposed patch fixing variable names in multiple sample files Some sample files had Item_DUE instead of Item_Due. In these cases the Item Due notices was shown as 'Unknown' in the message preferences table. Created attachment 4090 [details] [review] Signed off patch QA comment: Katrin/chris, I made some tests without this patch, my database contains Item_DUE in message_name column and can't see what is not working. Could you give more details ? + patch does not apply anymore Auto-merging installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.sql CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.sql Hi Paul, first of all consistency is a good reason - the message names should be the same everywhere and in all files. The second was display problems - I am not sure if something has changed here. In some places the name showed as Unknown because there was a case sensitive check for the message name. I am not totally sure now where this occured, places to check are: - patron categories: page and edit screen - patron X > details tab: page and edit screen - patron X's OPAC account > messaging tab katrin, thanks, I understand now. Marking does not apply, as it does not apply anymore Last patch is no longer needed as this is fixed in current master. |