Summary: | Adding multiple items from a cart to a list shows only the first title | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Lists | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, chris, chrish, gmcharlt, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 5894 - Adding multiple items from a cart to a list shows only the first title
Bug 5894 - Adding multiple items from a cart to a list shows only the first title Bug 5894 - Adding multiple items from a cart to a list shows only the first title |
Description
Owen Leonard
2011-03-18 14:46:01 UTC
Created attachment 19015 [details] [review] Bug 5894 - Adding multiple items from a cart to a list shows only the first title Adds missing code that splits biblios before calling template. To test: Add some items to cart Open cart, select some or all items Add to list With patch, following window shold show something like "Add 3 items to a list:", followed by list of items Created attachment 19289 [details] [review] Bug 5894 - Adding multiple items from a cart to a list shows only the first title Adds missing code that splits biblios before calling template. To test: Add some items to cart Open cart, select some or all items Add to list With patch, following window shold show something like "Add 3 items to a list:", followed by list of items Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> opac/opac-addbybiblionumber.pl and virtualshelves/addbybiblionumber.pl Duplicate a lot of subroutines, and code that should be in a subroutine, it would be a great job for a person new to Koha to write tests for the subroutines and then refactor them into a module. However this won't stop me signing off on this patch that does fix the problem Created attachment 19408 [details] [review] Bug 5894 - Adding multiple items from a cart to a list shows only the first title Adds missing code that splits biblios before calling template. To test: Add some items to cart Open cart, select some or all items Add to list With patch, following window shold show something like "Add 3 items to a list:", followed by list of items Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. Pushed to master. Thanks, Marc! This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Marc! Pushed to 3.10.x, will be in 3.10.10 Pushed to 3.8.x, will be in 3.8.17 |