Summary: | Authorities : allow users to search on all auth types | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | MARC Authority data support | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P3 | CC: | jonathan.druart, julian.maurice, koha.sekjal, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5581 | ||
Attachments: |
Proposed patch
proposed patch for T::TT Bug 5910: allow users to search on all auth types Bug 5910: only add "All authority types" for UNIMARC Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC |
Description
Chris Cormack
2011-03-20 22:45:30 UTC
Created attachment 3373 [details] [review] Proposed patch Hmm I cant see the send off patch anywhere, did you forget to send it Julian? Yes, sorry about that. Sent the rebased signed off patch. I still seem to be missing the signed off patch. Not on the mailing lists or attached. Julian I still cant find the signed off patch sorry :( Created attachment 4909 [details] [review] proposed patch for T::TT This patch add a "search on all authority type" select on the authorities search. It works for UNIMARC, i'm not sure at all it works for MARC21. Maybe it's related to other change in record.abs & things like that. Chris/anyone with a marc21 setup = could you test please = A signoff of a marc21 user is required. Patch applies. Testing procedure: - Added topical term: smith - Added personal name: smith, herbert On master: - A search with 'Default' brings up both authorities, all tabs Search Authorities Search Main Heading Search All Headings are working. After adding patch an additional entry is shown in the search pull down "All authority Types" I get the same search results for 'Default' and 'All Authority Types'. Small problem: After searching for 'Default' the pull down stays on 'Default', same for other frameworks. After searching for 'All Authority Types' it jumps back to 'Default'. I question if we need both? Where is the difference between both search options? As we also have a 'Default' framework for bibliographic cataloging I am not sure if renaming it might cause confusion. I am marking this 'Failed QA' becaue I don't see how this is useful and there is a small problem to be addressed if we want this to go in. I am putting this back to 'Needs Signoff' - my tests are invalid. I see now that both my records got added as 'Default', although I had chosen the named frameworks when adding them. Investigating. Sorry for causing confusion - tests ARE valid. The right types are in my auth_header table. It seems there is a display problem on the authority detail page. I am going to file a separate bug for that. Created attachment 10116 [details] [review] Bug 5910: allow users to search on all auth types Add search on "all authorities types" option in the authorities type select rewritten for T::T Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 10117 [details] [review] Bug 5910: only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. Created attachment 10249 [details] [review] Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Both patches together add the "all authority types" option for UNIMARC in a safe and sane way. Marking Passed QA. I've pushed the patches because they work as announced but I'd like to understand why
> UNIMARC is the only marcflavour that does not already have an option
> for searching all authority types, so check that the marcflavour is
> UNIMARC before displaying the additional "All authority types" option.
if it works under MARC21, why wouldn't we use the same method for UNIMARC ? How does it work for MARC21 ?
(In reply to comment #14) > if it works under MARC21, why wouldn't we use the same method for UNIMARC ? > How does it work for MARC21 ? Actually, the way it works for MARC21 can only be called... uhhh... weird? There is actually a blank authority type for MARC21, and since Zebra cannot search on blank fields, that is de facto the same as all authority types. The way UNIMARC does it is a lot better. (In reply to comment #15) > (In reply to comment #14) > > if it works under MARC21, why wouldn't we use the same method for UNIMARC ? > > How does it work for MARC21 ? > > Actually, the way it works for MARC21 can only be called... uhhh... weird? > There is actually a blank authority type for MARC21, and since Zebra cannot > search on blank fields, that is de facto the same as all authority types. > The way UNIMARC does it is a lot better. What about doing a follow-up like : * removing blank authority type in an updatedatabase * remove the [% if (unimarc) %] would it do the job ? (In reply to comment #16) > What about doing a follow-up like : > * removing blank authority type in an updatedatabase > * remove the [% if (unimarc) %] > would it do the job ? Unfortunately, it seems like old Koha installations are actually dependent on the "Default" authority type. I hope to reduce the dependency on the Default authority type with my work in the authority module, but as of right now, I don't think we can safely remove it. There have been no further reports of problems so I am marking this bug resolved. |