Bug 5914

Summary: BuildUnimarcHierarchies can go into an infinite loop in certain conditions
Product: Koha Reporter: Chris Cormack <chris>
Component: MARC Authority data supportAssignee: Henri-Damien LAURENT <henridamien>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: major    
Priority: PATCH-Sent (DO NOT USE) CC: jonathan.druart, julian.maurice, koha.sekjal
Version: 3.4   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 5926    
Bug Blocks: 5581    
Attachments: Proposed patch
Replacement patch
Replacement patch
Replacement patch

Description Chris Cormack 2011-03-21 02:52:06 UTC
When referenced authority in 5XX$3 would be the same as the current authid, the script would get into infinite loop
Comment 1 Chris Cormack 2011-03-21 02:53:20 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-03-21 22:36:27 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2011-03-22 11:16:15 UTC
I have an error:

Undefined subroutine &C4::AuthoritiesMarc::_get_authid_subfield called at /home/julian/koha/versions/koha-community-git/C4/AuthoritiesMarc.pm line 1134.
Comment 4 Julian Maurice 2011-03-22 13:55:19 UTC
(In reply to comment #3)
> I have an error:
> 
> Undefined subroutine &C4::AuthoritiesMarc::_get_authid_subfield called at
> /home/julian/koha/versions/koha-community-git/C4/AuthoritiesMarc.pm line 1134.

_get_authid_subfield is introduced by bug 5926.
Comment 5 Stéphane Delaune 2011-04-04 14:57:31 UTC Comment hidden (obsolete)
Comment 6 Stéphane Delaune 2011-04-05 08:47:58 UTC
Created attachment 3651 [details] [review]
Replacement patch

It's the same patch than 3637, but I forgot to define the others as obsoletes
Comment 7 Chris Cormack 2011-04-06 03:36:20 UTC
Pushed, please test